Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert shutdown_wait_unfinished_queries #49427

Merged
merged 2 commits into from May 3, 2023

Conversation

thevar1able
Copy link
Contributor

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Invert condition for shutdown_wait_unfinished_queries setting

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-bugfix Pull request with bugfix, not backported by default label May 2, 2023
@robot-ch-test-poll4
Copy link
Contributor

robot-ch-test-poll4 commented May 2, 2023

This is an automated comment for commit 4b43059 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟡 pending

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success

@nikitamikhaylov nikitamikhaylov self-assigned this May 2, 2023
@alexey-milovidov
Copy link
Member

Can we write an integration test?
It is not 100% necessary btw.

@nikitamikhaylov nikitamikhaylov merged commit 9d2a27c into master May 3, 2023
7 of 9 checks passed
@nikitamikhaylov nikitamikhaylov deleted the fix_shutdown_wait_unfinished_queries branch May 3, 2023 17:04
@nikitamikhaylov
Copy link
Member

There will be hard to write a reliable test...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants