-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ThreadPool::wait
#49572
Fix ThreadPool::wait
#49572
Conversation
if (shutdown) | ||
{ | ||
job_is_done = true; | ||
continue; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without job_is_done
scheduled_jobs
won't be decremented and job_finished.notify_all()
won't be called, so ThreadPool::wait
may hang.
This is an automated comment for commit 223adc1 with description of existing statuses. It's updated for the latest CI running
|
porting ClickHouse/ClickHouse#49572 on May 6 2023
* Fix parallel loading of data parts porting ClickHouse/ClickHouse#34310 on Feb 04, 2022 * Reset thread name in thread pool porting ClickHouse/ClickHouse#36115 on Apr 14, 2022 * ThreadPool fixes porting ClickHouse/ClickHouse#39160 on Jul 14, 2022 * Improve ThreadPool porting ClickHouse/ClickHouse#47657 on Mar 22, 2023 * Lower ThreadPool mutex contention and simplify porting ClickHouse/ClickHouse#48750 on Apr 14 * Fix ThreadPool::wait porting ClickHouse/ClickHouse#49572 on May 6 2023 * ProfileEvents added ContextLockWaitMicroseconds porting ClickHouse/ClickHouse#55029 (on Sep 26, 2023) * Fix race in Context::createCopy porting ClickHouse/ClickHouse#49663 * Use a separate mutex for query_factories_info in Context. porting ClickHouse/ClickHouse#37532 on May 26, 2022 * Avoid possible deadlock on server shutdown porting ClickHouse/ClickHouse#35081 on Mar 7, 2022 * Porting/issue 3238 context lock contention fix part 2 (#313)
Changelog category (leave one):