Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ThreadPool::wait #49572

Merged
merged 1 commit into from May 6, 2023

Conversation

CurtizJ
Copy link
Member

@CurtizJ CurtizJ commented May 5, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Comment on lines 399 to +403
if (shutdown)
{
job_is_done = true;
continue;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without job_is_done scheduled_jobs won't be decremented and job_finished.notify_all() won't be called, so ThreadPool::wait may hang.

@CurtizJ CurtizJ requested a review from serxa May 5, 2023 19:23
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented May 5, 2023

This is an automated comment for commit 223adc1 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 5, 2023
@alexey-milovidov alexey-milovidov self-assigned this May 5, 2023
@alexey-milovidov alexey-milovidov merged commit 26d435b into ClickHouse:master May 6, 2023
252 of 261 checks passed
yokofly added a commit to timeplus-io/proton that referenced this pull request Nov 14, 2023
chenziliang pushed a commit to timeplus-io/proton that referenced this pull request Nov 29, 2023
* Fix parallel loading of data parts
porting ClickHouse/ClickHouse#34310 on Feb 04, 2022

* Reset thread name in thread pool
porting ClickHouse/ClickHouse#36115 on Apr 14, 2022

* ThreadPool fixes
porting ClickHouse/ClickHouse#39160 on Jul 14, 2022

* Improve ThreadPool
porting ClickHouse/ClickHouse#47657 on Mar 22, 2023

* Lower ThreadPool mutex contention and simplify
porting ClickHouse/ClickHouse#48750 on Apr 14

* Fix ThreadPool::wait
porting ClickHouse/ClickHouse#49572 on May 6 2023

* ProfileEvents added ContextLockWaitMicroseconds
porting ClickHouse/ClickHouse#55029 (on Sep 26, 2023)

* Fix race in Context::createCopy
porting ClickHouse/ClickHouse#49663

* Use a separate mutex for query_factories_info in Context.
porting ClickHouse/ClickHouse#37532 on May 26, 2022

* Avoid possible deadlock on server shutdown
porting ClickHouse/ClickHouse#35081 on Mar 7, 2022

* Porting/issue 3238 context lock contention fix part 2 (#313)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants