Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix writing appended files to incremental backups #49725

Conversation

vitlibar
Copy link
Member

@vitlibar vitlibar commented May 10, 2023

Changelog category:

  • Bug Fix

Changelog entry:

Fix writing appended files to incremental backups. This bug could affect making backups for the tables of the Log family and also rarely for the definitions of tables.

@vitlibar vitlibar changed the title Fix incremental backups Fix writing appended files to incremental backups May 10, 2023
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-bugfix Pull request with bugfix, not backported by default label May 10, 2023
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented May 10, 2023

This is an automated comment for commit 478140f with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟢 success

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
Bugfix validate checkChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success


BufferBase::set(in->buffer().begin(), size, in->offset());
Copy link
Member Author

@vitlibar vitlibar May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the calculation was wrong. It started reading from the correct position but both the beginning and the end of the buffer were not adjusted correctly. As a result it correctly assigned the Content-Length for reading the appended file after the matched prefix, but passed a read buffer which couldn't read anything. As a result AWS SDK couldn't read anything from the passed read buffer and failed by timeout always.

@vitlibar vitlibar force-pushed the incremental-backup-append-table-def branch 3 times, most recently from 0a5e508 to 55ac7fa Compare May 11, 2023 12:11
@nikitamikhaylov nikitamikhaylov self-assigned this May 11, 2023
@vitlibar vitlibar force-pushed the incremental-backup-append-table-def branch from 55ac7fa to 478140f Compare May 11, 2023 20:58
@nikitamikhaylov nikitamikhaylov merged commit 66badcd into ClickHouse:master May 12, 2023
260 checks passed
@vitlibar vitlibar deleted the incremental-backup-append-table-def branch May 12, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created-cloud pr-bugfix Pull request with bugfix, not backported by default pr-must-backport-cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants