New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix writing appended files to incremental backups #49725
Fix writing appended files to incremental backups #49725
Conversation
This is an automated comment for commit 478140f with description of existing statuses. It's updated for the latest CI running
|
|
||
BufferBase::set(in->buffer().begin(), size, in->offset()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the calculation was wrong. It started reading from the correct position but both the beginning and the end of the buffer were not adjusted correctly. As a result it correctly assigned the Content-Length for reading the appended file after the matched prefix, but passed a read buffer which couldn't read anything. As a result AWS SDK couldn't read anything from the passed read buffer and failed by timeout always.
0a5e508
to
55ac7fa
Compare
55ac7fa
to
478140f
Compare
Changelog category:
Changelog entry:
Fix writing appended files to incremental backups. This bug could affect making backups for the tables of the Log family and also rarely for the definitions of tables.