-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to cast IPv6 to IPv4 for address in proper mapping block #49759
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
58bdcc2
allow to cast IPv6 to IPv4 for address in proper mapping block
yakov-olkhovskiy 108e256
allow to cast IPv4 to IPv6
yakov-olkhovskiy 24067ea
allow conversion for toIPv4OrDefault
yakov-olkhovskiy fc857aa
tests added
yakov-olkhovskiy 9443457
Merge branch 'master' into cast-ipv6-to-ipv4
yakov-olkhovskiy 0d4ed32
better exception message
yakov-olkhovskiy 3af7e0a
better exception message
yakov-olkhovskiy 09806bc
Merge branch 'master' into cast-ipv6-to-ipv4
yakov-olkhovskiy File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,10 @@ IPv4 functions | |
127.0.0.1 | ||
127.0.0.1 | ||
-- | ||
1.2.3.4 | ||
1.2.3.4 | ||
0.0.0.0 | ||
-- | ||
127.0.0.1 | ||
-- | ||
0 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+ test also with
toIPv4OrNull
? (just for completeness)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for historical reason
toIPv4OrNull
andtoIPv4OrZero
are not implemented with argument other than string - they are implementations of a string parser