New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept key value delimiter as part of value #49760
Accept key value delimiter as part of value #49760
Conversation
tests/queries/0_stateless/02499_extract_key_value_pairs_multiple_input.sql
Outdated
Show resolved
Hide resolved
@vdimir Hi, can you take a look at it pls? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is an automated comment for commit c16cba4 with description of existing statuses. It's updated for the latest CI running
|
@vdimir does CI need a re-run? Apparently, the failures are not related, but it does not seem like it'll restart itself |
0ca0b33
to
c16cba4
Compare
Hi @vdimir. I couldn't pin-point if the CI failures (Stress test (debug) and Upgrade check (debug)) are related to the PR, but I am under the impression they are not. If not, is there anything pending for this to be merged? |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Improve the "best-effort" parsing logic to accept
key_value_delimiter
as a valid part of the value. This also simplifies branching and might even speed up things a bit.Documentation entry for user-facing changes
Improve the "best-effort" parsing logic to accept
key_value_delimiter
as a valid part of the value. This also simplifies branching and might even speed up things a bit.