Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'initial_query_id' field for system.processors_profile_log #49777

Merged
merged 3 commits into from May 25, 2023

Conversation

helifu
Copy link
Contributor

@helifu helifu commented May 11, 2023

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Facilitate profile data association and aggregation for the same query

@CheSema CheSema self-assigned this May 12, 2023
@CheSema
Copy link
Member

CheSema commented May 12, 2023

Could you add some simple test here?

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-improvement Pull request with some product improvements label May 12, 2023
@robot-ch-test-poll3
Copy link
Contributor

robot-ch-test-poll3 commented May 12, 2023

This is an automated comment for commit cb130a1 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Docs CheckBuilds and tests the documentation🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 failure
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🔴 failure
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@CheSema
Copy link
Member

CheSema commented May 15, 2023

FYI:
Error: Cannot run, PR description does not match the template: Changelog entry required for category 'Improvement'
https://github.com/ClickHouse/ClickHouse/actions/runs/4947294382/jobs/8871234671?pr=49777

@clickhouse-ci
Copy link

clickhouse-ci bot commented May 16, 2023

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: More than one changelog category specified: 'Improvement', '###Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):'

@helifu
Copy link
Contributor Author

helifu commented May 17, 2023

Could you add some simple test here?

done.

@CheSema CheSema added the can be tested Allows running workflows for external contributors label May 22, 2023
@@ -5,16 +5,18 @@ This table contains profiling on processors level (that you can find in [`EXPLAI
Columns:

- `event_date` ([Date](../../sql-reference/data-types/date.md)) — The date when the event happened.
- `event_time` ([DateTime64](../../sql-reference/data-types/datetime64.md)) — The date and time when the event happened.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that. event_time is DateTime in the code indeed.

@helifu
Copy link
Contributor Author

helifu commented May 23, 2023

@CheSema
Seems the 'Fast Test' failed, but I don't know what's going on. Could you please give me some tips how to fix this failure?

@CheSema
Copy link
Member

CheSema commented May 24, 2023

@CheSema Seems the 'Fast Test' failed, but I don't know what's going on. Could you please give me some tips how to fix this failure?

Here the report.
https://s3.amazonaws.com/clickhouse-test-reports/49777/ec8f17a71ffa171a817965bc162d265c582fd5ab/fast_test.html

2023-05-22 15:23:03 -1
2023-05-22 15:23:03 \ No newline at end of file
2023-05-22 15:23:03 +1

When you make a tests, it is better to run it locally and just copy .output file as .reference.

@CheSema CheSema merged commit 23f894b into ClickHouse:master May 25, 2023
262 of 265 checks passed
@helifu helifu deleted the master1 branch May 25, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants