Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve grace_hash join by reserving hash table's size #49816

Merged
merged 6 commits into from May 24, 2023

Conversation

lgbo-ustc
Copy link
Contributor

@lgbo-ustc lgbo-ustc commented May 12, 2023

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Try to reserve hash table's size in grace_hash join.

for following query

CREATE TABLE t1 (key UInt32, s String) engine = TinyLog;
CREATE TABLE t2 (key UInt32, s String) engine = TinyLog;


insert into t1 select number as key, toString(number) as s from numbers(20000000);
insert into t2 select number as key, toString(number/3) as s from numbers(20000000);
select count(1) from (SELECT key FROM t1 AS t1 ALL LEFT JOIN t2 AS t2 USING (key) )t1 settings join_algorithm='grace_hash', max_rows_in_join=1000000;

before

1 row in set. Elapsed: 20.685 sec. Processed 40.00 million rows, 160.00 MB (1.93 million rows/s., 7.74 MB/s.)

after

1 row in set. Elapsed: 16.146 sec. Processed 40.00 million rows, 160.00 MB (2.48 million rows/s., 9.91 MB/s.)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@lgbo-ustc lgbo-ustc marked this pull request as ready for review May 12, 2023 06:46
@lgbo-ustc lgbo-ustc force-pushed the grace_hash_reserve_hash_table branch from 9809e57 to a737a34 Compare May 12, 2023 07:21
@vdimir vdimir self-assigned this May 12, 2023
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-performance Pull request with some performance improvements label May 12, 2023
@robot-ch-test-poll3
Copy link
Contributor

robot-ch-test-poll3 commented May 12, 2023

This is an automated comment for commit 0573d79 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 failure
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🔴 failure
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@nickitat nickitat added the can be tested Allows running workflows for external contributors label May 15, 2023
@lgbo-ustc lgbo-ustc force-pushed the grace_hash_reserve_hash_table branch 8 times, most recently from 7acbc39 to afba986 Compare May 22, 2023 02:18
@lgbo-ustc lgbo-ustc force-pushed the grace_hash_reserve_hash_table branch from 1b7bb19 to 0573d79 Compare May 22, 2023 09:47
@lgbo-ustc
Copy link
Contributor Author

There are 3 failures, but I think they are not related to this pr. @vdimir

@vdimir
Copy link
Member

vdimir commented May 24, 2023

Great!
image

@vdimir vdimir merged commit 3f892ce into ClickHouse:master May 24, 2023
256 of 259 checks passed
@tavplubix
Copy link
Member

@vdimir
Copy link
Member

vdimir commented May 24, 2023

Is there a chance it could break join_set_filter? https://s3.amazonaws.com/clickhouse-test-reports/0/3f892ceb12b868b1b9deb0607a7df2dde5f1a139/performance_comparison_[1_4]/report.html

@tavplubix It shouldn't, I'll check the reason

@vdimir
Copy link
Member

vdimir commented May 25, 2023

I have checked the failure join_set_filter it's not related to any change, but some queries in this tests is not really stable and pretty long, I suppose we should remove them #50235

vdimir added a commit that referenced this pull request Jun 8, 2023
…h_table"

This reverts commit 3f892ce, reversing
changes made to 32ffa2a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-performance Pull request with some performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants