Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaEngine: Allow usage of Alias column type #49824

Merged
merged 1 commit into from May 15, 2023

Conversation

AVMusorin
Copy link
Contributor

@AVMusorin AVMusorin commented May 12, 2023

Column ALIASes works as expected (unlike MATERIALIZED / EPHEMERAL or columns with default expression), so we can allow to use them for KafkaEngine.

Example:

create table kafka
(
   a UInt32,
   a_str String Alias toString(a)
) engine = Kafka;

create table data
(
    a UInt32;
    a_str String
) engine = MergeTree
order by tuple();

create materialized view data_mv to data
(
    a UInt32,
    a_str String
) as
select a, a_str from kafka;

Ref: #47138 (cc @rschu1ze )

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

The Kafka table engine now allows to use alias columns.

docs/en/engines/table-engines/integrations/kafka.md Outdated Show resolved Hide resolved
src/Storages/Kafka/StorageKafka.cpp Outdated Show resolved Hide resolved
@azat
Copy link
Collaborator

azat commented May 12, 2023

Allow using Alias column type for KafkaEngine

Also better to add information to the changelog entry why this can be useful (MVs with explicit table does not allow to have extra fields)

@AVMusorin AVMusorin force-pushed the allow-alias-column-kafka branch 2 times, most recently from 151ec95 to a909a10 Compare May 12, 2023 16:36
@rschu1ze rschu1ze self-assigned this May 12, 2023
@rschu1ze rschu1ze added the can be tested Allows running workflows for external contributors label May 12, 2023
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-improvement Pull request with some product improvements label May 12, 2023
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented May 12, 2023

This is an automated comment for commit 418a61a with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🔴 failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Docs CheckBuilds and tests the documentation🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 failure
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🔴 failure
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@rschu1ze rschu1ze changed the title Allow using Alias column type for KafkaEngine KafkaEngine: Allow usage of Alias column type May 13, 2023
src/Storages/Kafka/StorageKafka.cpp Outdated Show resolved Hide resolved
src/Storages/Kafka/StorageKafka.cpp Outdated Show resolved Hide resolved
```
create table kafka
(
 a UInt32,
 a_str String Alias toString(a)
) engine = Kafka;

create table data
(
  a UInt32;
  a_str String
) engine = MergeTree
order by tuple();

create materialized view data_mv to data
(
  a UInt32,
  a_str String
) as
select a, a_str from kafka;
```
Alias type works as expected in comparison with MATERIALIZED/EPHEMERAL
or column with default expression.

Ref: ClickHouse#47138

Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
@rschu1ze rschu1ze merged commit 59bc3e2 into ClickHouse:master May 15, 2023
258 of 264 checks passed
@AVMusorin AVMusorin deleted the allow-alias-column-kafka branch May 16, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants