New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KafkaEngine: Allow usage of Alias column type #49824
Merged
rschu1ze
merged 1 commit into
ClickHouse:master
from
AVMusorin:allow-alias-column-kafka
May 15, 2023
Merged
KafkaEngine: Allow usage of Alias column type #49824
rschu1ze
merged 1 commit into
ClickHouse:master
from
AVMusorin:allow-alias-column-kafka
May 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azat
reviewed
May 12, 2023
Also better to add information to the changelog entry why this can be useful (MVs with explicit table does not allow to have extra fields) |
AVMusorin
force-pushed
the
allow-alias-column-kafka
branch
2 times, most recently
from
May 12, 2023 16:36
151ec95
to
a909a10
Compare
rschu1ze
added
the
can be tested
Allows running workflows for external contributors
label
May 12, 2023
robot-ch-test-poll1
added
the
pr-improvement
Pull request with some product improvements
label
May 12, 2023
This is an automated comment for commit 418a61a with description of existing statuses. It's updated for the latest CI running
|
rschu1ze
changed the title
Allow using Alias column type for KafkaEngine
KafkaEngine: Allow usage of Alias column type
May 13, 2023
rschu1ze
reviewed
May 13, 2023
``` create table kafka ( a UInt32, a_str String Alias toString(a) ) engine = Kafka; create table data ( a UInt32; a_str String ) engine = MergeTree order by tuple(); create materialized view data_mv to data ( a UInt32, a_str String ) as select a, a_str from kafka; ``` Alias type works as expected in comparison with MATERIALIZED/EPHEMERAL or column with default expression. Ref: ClickHouse#47138 Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
AVMusorin
force-pushed
the
allow-alias-column-kafka
branch
from
May 15, 2023 13:40
a909a10
to
418a61a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-improvement
Pull request with some product improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Column
ALIAS
es works as expected (unlikeMATERIALIZED
/EPHEMERAL
or columns with default expression), so we can allow to use them for KafkaEngine.Example:
Ref: #47138 (cc @rschu1ze )
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
The Kafka table engine now allows to use alias columns.