New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new profile events for queries with subqueries #50204
Conversation
This is an automated comment for commit 2e34700 with description of existing statuses. It's updated for the latest CI running
|
Well. I think it is a good PR. |
What happens if InterpreterSelectQueryAnalyzer runs instead when allow_experimental_analyzer is true? |
@azat ok, but the name is confusing. Let's rename it to something else, like SelectQueriesWithViews... |
9e42041
to
6a16c8e
Compare
Differs from SelectQuery/InsertQuery that it could be > 1 (in case of MATERIALIZED VIEW attached to the table), since each local SELECT/INSERT query is accounted, not only initial. Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
6a16c8e
to
6b5933a
Compare
@alexey-milovidov Indeed, though this is not only about views, but subqueries as well, I think
@CheSema Ok, let's do this to make it less transparent for user.
Now it does (tests had been updated as well).
Good catch! Fixed. |
Settings does not contains unchanged values, and the value is considered unchanged, if it matches the default. So simply use the shell variable instead of Settings. Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Test failures does not looks related:
ClickHouse Stateless Tests (release, DatabaseReplicated) [2/4]
|
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add new profile events for queries with subqueries (
QueriesWithSubqueries
/SelectQueriesWithSubqueries
/InsertQueriesWithSubqueries
)