New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clickhouse-client: disallow usage of --query
and --queries-file
at the same time
#50210
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This is an automated comment for commit 82d2a7b with description of existing statuses. It's updated for the latest CI running
|
--query
and --queries-file
at the same time
tests/queries/0_stateless/01523_client_local_queries_file_parameter.sh
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Lgtm. CI won't let me merge, I restarted some tests. If that also doesn't help, please merge from |
Silly me, I somehow added prefix "ClickHouse" to the restarted tests, with the result that 1. they are not restarted (because no such tests exist) and 2. they block merge. @Demilivor Better click "Update branch", otherwise we'll be stuck for all eternity 😄 |
Robert, it's not a problem. @Demilivor will update the branch in few hours, he is in GMT+10 time zone. |
It looks like these tests are stuck. UPD: |
CI is currently trash. Please don't merge master again, I restarted the failing tests manually. |
The reason for the falling tests is probably because of actions/runner#2582 |
Closes #49769
And just as an idea:
Recent PR #49970 hints a better solution which is running from any "source" in the order of console arguments, e.g.:
This PR does not add this behavior, it only indicates a further improvement
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
clickhouse-client now forbids usage of "--query" and "--queries-file" at the same time