Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix endian issues in native protocol #50267

Merged

Conversation

HarryLeeIBM
Copy link
Contributor

Since native protocol reads and writes raw data of numeric values in memory directly, it causes issues that clients on little-endian machines and clients on big-endian machine cannot exchange data correctly.

The fix is to ensure native protocol uses little-endian to avoid these endian issues.

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed endian issues in native protocol.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-build Pull request with build/testing/packaging improvement label May 27, 2023
@robot-ch-test-poll2
Copy link
Contributor

robot-ch-test-poll2 commented May 27, 2023

This is an automated comment for commit 1645439 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟡 pending

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@davenger davenger added the can be tested Allows running workflows for external contributors label May 27, 2023
@yakov-olkhovskiy yakov-olkhovskiy self-assigned this May 31, 2023
src/IO/ReadHelpers.h Outdated Show resolved Hide resolved
src/IO/WriteHelpers.h Outdated Show resolved Hide resolved
src/DataTypes/Serializations/SerializationNumber.cpp Outdated Show resolved Hide resolved
src/DataTypes/Serializations/SerializationNumber.cpp Outdated Show resolved Hide resolved
@HarryLeeIBM HarryLeeIBM marked this pull request as draft June 27, 2023 13:28
@alexey-milovidov
Copy link
Member

@HarryLeeIBM, you need to add s390x to CI to speed up the processing of your pull requests.
See #31398 as an example.

@HarryLeeIBM HarryLeeIBM marked this pull request as ready for review August 18, 2023 12:52
@HarryLeeIBM
Copy link
Contributor Author

@yakov-olkhovskiy, the build only has 2 failing which are not related to this change. Could you review the PR? Thanks!

@yakov-olkhovskiy yakov-olkhovskiy merged commit 257380d into ClickHouse:master Aug 19, 2023
285 of 288 checks passed
@HarryLeeIBM HarryLeeIBM deleted the hlee-s390x-proto-endian branch August 23, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-build Pull request with build/testing/packaging improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants