Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MergeTree & SipHash checksum big-endian support #50276

Conversation

ltrk2
Copy link
Contributor

@ltrk2 ltrk2 commented May 26, 2023

The changes are meant to fix the 00961_checksums_in_system_parts_columns_table functional test suite.

Marks are now always serialized as little-endian to ensure interoperability between platforms. Composite structures are now transformed correctly from big-endian to little-endian when computing hashes using SipHash.

The handling of 128-bit checksums used for total checksum calculation consisting of two 64-bit unsigned integers was inconsistent in some cases: in big-endian mode CityHash returns them in a lo, hi component order and only the values of the components are big-endian, whereas SipHash returns a more canonical version as hi, lo with both the order of components and their values following big-endian convention. However, when reusing the output data structure of CityHash (i.e. std::pair<uint64_t, uint64_t>) SipHash now has a get128LoHi function that follows the lo, hi component order no matter what endianness the platform is so that the resulting hashes are comparable without having to know which algorithm they were produced by.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@ltrk2 ltrk2 changed the title Feature/mergetree checksum big endian support MergeTree / SipHash checksum big endian support May 26, 2023
@ltrk2 ltrk2 changed the title MergeTree / SipHash checksum big endian support MergeTree & SipHash checksum big endian support May 26, 2023
@ltrk2 ltrk2 changed the title MergeTree & SipHash checksum big endian support MergeTree & SipHash checksum big-endian support May 26, 2023
@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label May 28, 2023
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 28, 2023
@robot-clickhouse-ci-1
Copy link
Contributor

robot-clickhouse-ci-1 commented May 28, 2023

This is an automated comment for commit 14977e6 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🔴 failure
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🔴 failure

@ltrk2 ltrk2 force-pushed the feature/mergetree-checksum-big-endian-support branch 2 times, most recently from 0b788bb to 1f49e25 Compare May 29, 2023 16:38
@rschu1ze

This comment was marked as outdated.

src/Common/SipHash.h Outdated Show resolved Hide resolved
src/Common/SipHash.h Outdated Show resolved Hide resolved
src/Common/SipHash.h Outdated Show resolved Hide resolved
src/Common/SipHash.h Outdated Show resolved Hide resolved
src/Common/SipHash.h Outdated Show resolved Hide resolved
src/Common/SipHash.h Outdated Show resolved Hide resolved
src/Common/SipHash.h Outdated Show resolved Hide resolved
src/Common/SipHash.h Outdated Show resolved Hide resolved
@ltrk2 ltrk2 force-pushed the feature/mergetree-checksum-big-endian-support branch from 72ebdfc to 02c3e80 Compare June 22, 2023 03:15
@ltrk2

This comment was marked as outdated.

@ltrk2 ltrk2 requested a review from rschu1ze June 22, 2023 16:21
@rschu1ze

This comment was marked as outdated.

@ltrk2 ltrk2 force-pushed the feature/mergetree-checksum-big-endian-support branch 2 times, most recently from fc5f20f to 5cfd462 Compare June 23, 2023 19:26
rschu1ze

This comment was marked as outdated.

@ltrk2 ltrk2 force-pushed the feature/mergetree-checksum-big-endian-support branch from 5cfd462 to 1f5bdae Compare June 26, 2023 13:08
@ltrk2

This comment was marked as outdated.

@rschu1ze
Copy link
Member

As there are currently many failing tests in ClickHouse's CI, a policy was put in place which prevents merging of PRs with red tests, even if unrelated.
@ltrk2 as a contributor, you are of course not obliged to fix these tests (it's appreciated, though). Until the situation stabilizes, this PR is on hold. Maybe merge from master once in a while (please not too often), and with a bit of luck all tests are green.

@ltrk2
Copy link
Contributor Author

ltrk2 commented Jun 27, 2023

@rschu1ze thanks for the heads-up!

@ltrk2 ltrk2 force-pushed the feature/mergetree-checksum-big-endian-support branch 2 times, most recently from 11e37ca to 8d836a6 Compare June 29, 2023 17:07
@rschu1ze

This comment was marked as outdated.

@ltrk2

This comment was marked as outdated.

@ltrk2 ltrk2 force-pushed the feature/mergetree-checksum-big-endian-support branch from 8d836a6 to f6850f0 Compare July 6, 2023 00:36
@robot-ch-test-poll robot-ch-test-poll added the submodule changed At least one submodule changed in this PR. label Jul 6, 2023
@rschu1ze

This comment was marked as outdated.

@ltrk2 ltrk2 force-pushed the feature/mergetree-checksum-big-endian-support branch from 035c3e6 to c313b9e Compare July 6, 2023 14:57
@ltrk2 ltrk2 force-pushed the feature/mergetree-checksum-big-endian-support branch from 7fe0179 to 1208e59 Compare July 19, 2023 17:02
@rschu1ze

This comment was marked as outdated.

@ltrk2

This comment was marked as outdated.

@rschu1ze

This comment was marked as outdated.

@ltrk2

This comment was marked as outdated.

@rschu1ze

This comment was marked as outdated.

@alexey-milovidov

This comment was marked as outdated.

@ltrk2 ltrk2 force-pushed the feature/mergetree-checksum-big-endian-support branch from a1abfde to 14977e6 Compare August 16, 2023 19:38
@rschu1ze rschu1ze merged commit ec7daed into ClickHouse:master Aug 17, 2023
264 of 273 checks passed
baibaichen added a commit to Kyligence/gluten that referenced this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants