Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Annoy index #50312

Merged
merged 62 commits into from
Jun 8, 2023
Merged

Cleanup Annoy index #50312

merged 62 commits into from
Jun 8, 2023

Conversation

rschu1ze
Copy link
Member

Some cleanup of the Annoy index. See the individual commits for details.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 29, 2023
@robot-ch-test-poll4
Copy link
Contributor

robot-ch-test-poll4 commented May 29, 2023 •
edited

This is an automated comment for commit 1b26901 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟡 pending

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
Mergeable CheckChecks if all other necessary checks are successful🟢 success

@nickitat nickitat self-assigned this May 31, 2023
@alexey-milovidov alexey-milovidov mentioned this pull request Jun 2, 2023
Closed
@rschu1ze
Copy link
Member Author

rschu1ze commented Jun 4, 2023

@nickitat Not urgent but like to check this PR?

@rschu1ze
Cosmetics: Fix indentation
3657ef0
@rschu1ze
Cosmetics: Remove parentheses in single statement if/for/while
3275629
@rschu1ze
Cosmetics: Minor aesthetic fixes
edad92a
@rschu1ze
Cosmetics: Move ctors into cpp file
1018677
@rschu1ze
Cosmetics: number_of_trees --> trees
4631595
@rschu1ze
Cosmetics: Move ErrorCodes to top
a8bf7af
@rschu1ze
Cosmetics: Remove absolute namespace qualification of Annoy library i…
f8c1f2b 
…nternals
@rschu1ze
Cosmetics: Unwrap Annoy index from nested namespace
e373cf6
@rschu1ze
Cosmetics: Factorize repeated typedefs into a single typedef
dc88d4e
@rschu1ze
Cosmetics: AnnoyIndex --> AnnoyIndexWithSerialization
594572b
@rschu1ze
Cosmetics: Switch arguments in MTIConditionAnnoy ctor
c5ededd
@rschu1ze
Cosmetics: Remove dots from exception messages
3b77e40
@rschu1ze
Cosmetics: Remove unnecessary toString()
423f692
@rschu1ze
Cosmetics: more constness
7608e08
@rschu1ze
Cosmetics: Update exception messages
a3d4ede
@rschu1ze
Cosmetics: make input switch a bit more idiomatic
2b74daa
@rschu1ze
Cosmetics: unglue * and &
68ad903
@rschu1ze
Cosmetics: add some comments + minor changes
15c9e23
@rschu1ze
Cosmetics: Move assertIndexColumnsType() into annoyIndexValidator()
828155e
@rschu1ze
Cosmetics: Rename variable
0854d91
@rschu1ze
Cosmetics: Factorize throw into lambda
62c8b9a
@rschu1ze
Cosmetics: +comments
5d871c7
@rschu1ze
Simplify Annoy parameterization
f577bf3
@rschu1ze
Cosmetics: distance_name --> distance_function
03b6856
@rschu1ze
Check distance function in CREATE TABLE instead of first INSERT
18304f5
This was referenced Jun 7, 2023
Merged
Closed
@rschu1ze rschu1ze merged commit 56df9f3 into ClickHouse:master Jun 8, 2023
5 of 10 checks passed
@rschu1ze rschu1ze mentioned this pull request Jun 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickitat nickitat nickitat approved these changes

Assignees

@nickitat nickitat

Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rschu1ze @robot-ch-test-poll4 @nickitat