New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bitShift* functions with both constant arguments #50343
Conversation
This is an automated comment for commit c87e8c1 with description of existing statuses. It's updated for the latest CI running
|
@@ -1741,7 +1741,7 @@ ColumnPtr executeStringInteger(const ColumnsWithTypeAndName & arguments, const A | |||
OpImpl::template processString<OpCase::Vector>(in_vec.data(), col_left->getOffsets().data(), &value, out_vec, out_offsets, 1); | |||
} | |||
|
|||
return ColumnConst::create(std::move(col_res), col_left->size()); | |||
return ColumnConst::create(std::move(col_res), col_left_const->size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why doesn't it useDefaultImplementationForConstants?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is even separarate function FunctionBinaryArithmeticWithConstants
for working with constants. I don't know why we have it, probably it's optimized somehow
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix bitShift* functions with both constant arguments.
Closes #50236
Closes #50266
Closes #50282
Documentation entry for user-facing changes