Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to skip empty files in file/s3/url/hdfs table functions #50364

Merged
merged 12 commits into from Jun 16, 2023

Conversation

Avogar
Copy link
Member

@Avogar Avogar commented May 30, 2023

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Allow to skip empty files in file/s3/url/hdfs table functions using settings s3_skip_empty_files, hdfs_skip_empty_files, engine_file_skip_empty_files, engine_url_skip_empty_files.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll robot-ch-test-poll added the pr-feature Pull request with new product feature label May 30, 2023
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented May 30, 2023

This is an automated comment for commit 1f47bb7 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🔴 failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docs CheckBuilds and tests the documentation🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🔴 failure

@Avogar Avogar marked this pull request as ready for review June 1, 2023 14:56
Copy link
Member

@al13n321 al13n321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I hope we'll eventually refactor these 4 storages to have less copy-pasta.)

docs/en/operations/settings/settings.md Outdated Show resolved Hide resolved
docs/en/engines/table-engines/special/file.md Outdated Show resolved Hide resolved
docs/en/operations/settings/settings.md Show resolved Hide resolved
docs/en/operations/settings/settings.md Show resolved Hide resolved
docs/en/sql-reference/table-functions/file.md Outdated Show resolved Hide resolved
src/Storages/StorageFile.cpp Outdated Show resolved Hide resolved
src/Storages/StorageS3.cpp Outdated Show resolved Hide resolved
src/Storages/StorageURL.cpp Outdated Show resolved Hide resolved
src/Storages/StorageURL.cpp Outdated Show resolved Hide resolved
src/Storages/StorageURL.cpp Outdated Show resolved Hide resolved
@Avogar Avogar requested a review from al13n321 June 13, 2023 14:46
Copy link
Member

@al13n321 al13n321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except plz add skipping in {x|y|z} url globs too.

CUR_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
# shellcheck source=../shell_config.sh
. "$CUR_DIR"/../shell_config.sh

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, TIL that nonempty stderr fails the test.

src/Storages/HDFS/StorageHDFS.cpp Outdated Show resolved Hide resolved
src/Storages/HDFS/StorageHDFS.cpp Outdated Show resolved Hide resolved
src/Storages/StorageURL.cpp Show resolved Hide resolved
@Avogar Avogar merged commit dcc3efe into ClickHouse:master Jun 16, 2023
55 of 159 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants