New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CRC32(WeakHash) issue for s390x #50365
Fix CRC32(WeakHash) issue for s390x #50365
Conversation
This is an automated comment for commit 1b403ab with description of existing statuses. It's updated for the latest CI running
|
34afdcf
to
1b403ab
Compare
We don't have any means to test or check this code, and we don't have s390x build in the CI system, |
@HarryLeeIBM please check this PR #31398 and add the s390x build to CI accordingly. |
On s390x, WeakHash related code generates different hash values compared to x86. This fails the unit test for
WeakHash32
and functional test00558_aggregate_merge_totals_with_arenas
. The reason is that the code for s390x uses CRC32 instead of CRC32C, and hashes big-endian of integers instead of little-endian.The fix fixes the above issues and also uses "_vx" version of s390x crc32c functions to utilize hardware acceleration of s390x.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed CRC32(WeakHash32) issue for s390x.
Documentation entry for user-facing changes