Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump protobuf to v3.18.x #50400

Merged
merged 8 commits into from Jun 2, 2023
Merged

Bump protobuf to v3.18.x #50400

merged 8 commits into from Jun 2, 2023

Conversation

rschu1ze
Copy link
Member

@rschu1ze rschu1ze commented May 31, 2023

This PR

Most of the custom patches in the previous repository seem no longer necessary, so they were not transferred (though I have the feeling that we'll need one or two, let's see what CI says A msan fix was transferred, that's all.).

@larryluogit

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Bump internal protobuf to v3.18 (fixes CVE-2022-1941)

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added pr-improvement Pull request with some product improvements submodule changed At least one submodule changed in this PR. labels May 31, 2023
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented May 31, 2023

This is an automated comment for commit 9490cd4 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 failure
Mergeable CheckChecks if all other necessary checks are successful🔴 failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@rschu1ze rschu1ze changed the title Bump protobuf Bump protobuf to v3.18.x May 31, 2023
@rschu1ze
Copy link
Member Author

Note to myself: archive the old protobuf repo.

@alexey-milovidov alexey-milovidov self-assigned this Jun 1, 2023
@rschu1ze rschu1ze marked this pull request as ready for review June 1, 2023 13:16
@alexey-milovidov alexey-milovidov merged commit eb5985e into master Jun 2, 2023
225 of 245 checks passed
@alexey-milovidov alexey-milovidov deleted the bump-protobuf branch June 2, 2023 02:01
baibaichen added a commit to Kyligence/gluten that referenced this pull request Jun 3, 2023
@baibaichen
Copy link
Contributor

This version has an issue, see protocolbuffers/protobuf#9378. it's better to upgrade to newer version.

@alexey-milovidov
Copy link
Member

@baibaichen, does it affect the correctness?

zzcclp pushed a commit to apache/incubator-gluten that referenced this pull request Jun 3, 2023
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20230603)

* Fix Build since ClickHouse/ClickHouse#50400

* Fix Build since ClickHouse/ClickHouse#49539

* Workaround protoc's issue(protocolbuffers/protobuf#9378).

---------

Co-authored-by: kyligence-git <gluten@kyligence.io>
Co-authored-by: Chang Chen <baibaichen@gmail.com>
@baibaichen
Copy link
Contributor

baibaichen commented Jun 3, 2023

@alexey-milovidov I am not clear how it affects correctness, we workaround it with -Wno-shadow-field, and basic UTs show no correctness issue.

But, it is definitely an issue.​

@alexey-milovidov
Copy link
Member

We include the 3rd-party libraries as -isystem, so it does not matter for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements submodule changed At least one submodule changed in this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants