New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump protobuf to v3.18.x #50400
Bump protobuf to v3.18.x #50400
Conversation
This is an automated comment for commit 9490cd4 with description of existing statuses. It's updated for the latest CI running
|
Note to myself: archive the old protobuf repo. |
This version has an issue, see protocolbuffers/protobuf#9378. it's better to upgrade to newer version. |
@baibaichen, does it affect the correctness? |
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20230603) * Fix Build since ClickHouse/ClickHouse#50400 * Fix Build since ClickHouse/ClickHouse#49539 * Workaround protoc's issue(protocolbuffers/protobuf#9378). --------- Co-authored-by: kyligence-git <gluten@kyligence.io> Co-authored-by: Chang Chen <baibaichen@gmail.com>
@alexey-milovidov I am not clear how it affects correctness, we workaround it with But, it is definitely an issue. |
We include the 3rd-party libraries as |
This PR
Most of the custom patches in the previous repository seem no longer necessary, so they were not transferred (
though I have the feeling that we'll need one or two, let's see what CI saysA msan fix was transferred, that's all.).@larryluogit
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Bump internal protobuf to v3.18 (fixes CVE-2022-1941)