New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not read all the columns from right GLOBAL JOIN table. #50721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll1
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Jun 8, 2023
This is an automated comment for commit 350becb with description of existing statuses. It's updated for the latest CI running
|
KochetovNicolai
added
the
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
label
Jun 8, 2023
I also implemented this feature, but it's too late to submit. You're ahead, what a pity ~~~><~~~ |
nikitamikhaylov
approved these changes
Jun 9, 2023
This was referenced Jun 9, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Jun 9, 2023
KochetovNicolai
added a commit
that referenced
this pull request
Jun 9, 2023
…c05221d998aec960dc4cdc756e579 Cherry pick #50721 to 23.2: Do not read all the columns from right GLOBAL JOIN table.
KochetovNicolai
added a commit
that referenced
this pull request
Jun 9, 2023
Backport #50721 to 23.5: Do not read all the columns from right GLOBAL JOIN table.
robot-clickhouse
added a commit
that referenced
this pull request
Jun 9, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Jun 9, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Jun 9, 2023
robot-clickhouse-ci-1
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Jun 9, 2023
KochetovNicolai
added a commit
that referenced
this pull request
Jun 12, 2023
Backport #50721 to 22.8: Do not read all the columns from right GLOBAL JOIN table.
KochetovNicolai
added a commit
that referenced
this pull request
Jun 12, 2023
Backport #50721 to 23.4: Do not read all the columns from right GLOBAL JOIN table.
KochetovNicolai
added a commit
that referenced
this pull request
Jun 12, 2023
Backport #50721 to 23.3: Do not read all the columns from right GLOBAL JOIN table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Queries with
GLOBAL JOIN
read all the columns from the right table. Now, only needed columns are read.Looks like this was always broken.
This PR is also performance improvement.