Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support visiting S3 by assume role #50742

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

binmahone
Copy link
Contributor

Changelog category (leave one):

  • Improvement

this PR is to support visiting S3 by assume role (https://docs.aws.amazon.com/STS/latest/APIReference/API_AssumeRole.html)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Documentation entry for user-facing changes

@binmahone
Copy link
Contributor Author

@antonio2368 can you please help to review this?

@antonio2368 antonio2368 self-assigned this Jun 9, 2023
@antonio2368
Copy link
Member

@binmahone the changes and the feature are useful but we are planning on refactoring our S3 configuration/authentication because it became a bit too messy and hard to maintain.
For example, you didn't expose the feature in any way (through config or function argument) and that is exactly the part that is too complex now. I would like to put this PR on hold until the refactoring is done if that's okay from your side.

@binmahone
Copy link
Contributor Author

sure, I can wait. BTW, do you have an ETA for the refactoring?

@binmahone
Copy link
Contributor Author

@antonio2368 do we have any update on the S3 configuration/authentication refactor task?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants