New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid storing logs in Keeper containing unknown operation #50751
Conversation
@@ -39,7 +39,7 @@ struct ChangelogRecordHeader | |||
ChangelogVersion version = CURRENT_CHANGELOG_VERSION; | |||
uint64_t index = 0; /// entry log number | |||
uint64_t term = 0; | |||
nuraft::log_val_type value_type{}; | |||
int32_t value_type{}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an automated comment for commit a3da7c8 with description of existing statuses. It's updated for the latest CI running
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are good, but I think we need to add rolling update integration test.... Otherwise we will see something similar soon...
Yes, agree |
Backport #50751 to 23.5: Avoid storing logs in Keeper containing unknown operation
Backport #50751 to 23.3: Avoid storing logs in Keeper containing unknown operation
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Keeper fix: avoid storing logs containing invalid operations so the instance doesn't end up in an invalid state.
Documentation entry for user-facing changes