New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show halves of checksums in correct order #51040
Show halves of checksums in correct order #51040
Conversation
This is an automated comment for commit 5570863 with description of existing statuses. It's updated for the latest CI running
|
base/base/wide_integer_impl.h
Outdated
@@ -281,6 +288,14 @@ struct integer<Bits, Signed>::_impl | |||
} | |||
} | |||
|
|||
constexpr static void wide_integer_from_cityhash_uint128(integer<Bits, Signed> & self, const CityHash_v1_0_2::uint128 & value) noexcept |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CityHash_v1_0_2::uint128
is not tuple-like anymore so I had to add this function to implement conversion CityHash_v1_0_2::uint128
-> UInt128
.
a759820
to
bf6fa7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the changelog entry, could you please clarify that we use the BigEndian order (if I am not mistaken) instead of saying "correct order"?
Apart from this and the failing tests it looks good to me.
… "second" -> "high64".
It's like that, but not exactly. Big endian is about representation in memory, not in output. And this PR is only about output representation. It changes the output representation into always using positional notation as we always do when we write numbers. I mean for example the hash
And before this PR it the same hash
|
bf6fa7f
to
6999b1a
Compare
6999b1a
to
71cded0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification, it makes sense!
Test test_ssl_cert_authentication/test.py::test_https_non_ssl_auth is known to be flaky (#49400). |
Changelog category:
Changelog entry:
Show halves of checksums in
system.parts
,system.projection_parts
and in error messages in the correct order.This PR changes only output representation of hashes. It changes the output representation into always using positional notation as we always do when we write numbers. For example the hash
ffeeddccbbaa99887766554433221100
will now always meanAnd before this PR it the same hash
ffeeddccbbaa99887766554433221100
could sometimes meanAlso this PR introduces better names for member fields of the
CityHash_v1_0_2::uint128
struct (first
,second
were renamed tolow64
,high64
).