Log async insert flush queries into to system.query_log and system.processes

[Algunenano]

Changelog category (leave one):

• Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

• Log async insert flush queries into to system.query_log

Documentation entry for user-facing changes

Flush queries for async inserts (the queries that do the final push of data) are now logged in the system.query_log where they appear as query_kind = 'AsyncInsertFlush'.

These flush queries also now appear in system.processes and can be killed as any normal insert, but they don't count towards the limits for max concurrent queries.

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

Closes #50720

[robot-clickhouse-ci-1]

This is an automated comment for commit 09a6472 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟢 success

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	🟢 success
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	🟢 success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	🟢 success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	🟢 success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	🟢 success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	🟢 success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	🟢 success
Install packages	Checks that the built packages are installable in a clear environment	🟢 success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	🟢 success
Mergeable Check	Checks if all other necessary checks are successful	🟢 success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	🟢 success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	🟢 success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	🟢 success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	🟢 success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	🟢 success
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	🟢 success
Unit tests	Runs the unit tests for different release types	🟢 success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	🟢 success

[Algunenano]

There are some issues in the tests, related to the handling of the new AsyncInsertFlush query kind. I'm going to move it to the AST instead instead of passing flags everywhere.

[Algunenano]

• Integration tests (asan) [1/6] -> test_profile_events_s3/test.py::test_profile_events flaky test #50543
• ClickHouse Stress Test (ubsan) -> Logical error: 'Read unexpected size. ...' #50468
• Stateless tests (release, analyzer) -> Experimental and unrelated

I'll keep an eye on the rest of the tests as they advance, but I think this is ok to review now.

[Algunenano]

Failed tests are all unrelated:

• Integration tests (asan) [4/6] — fail: 1, passed: 266, flaky: 0
  test_multiple_disks/test.py::test_start_stop_moves[replicated] -> Flaky test_multiple_disks #45404
• Integration tests (release) [3/4] — fail: 1, passed: 558, flaky: 0
  test_alter_moving_garbage/test.py::test_create_table[False-True] -> Flaky test_alter_moving_garbage/test.py::test_create_table[False-False] #51342
• Integration tests (release) [4/4] — fail: 1, passed: 425, flaky: 0
  test_ssl_cert_authentication/test.py::test_https_non_ssl_auth -> Flaky test test_ssl_cert_authentication #49400
• Integration tests (tsan) [4/6] — fail: 1, passed: 266, flaky: 0
  test_multiple_disks/test.py::test_start_stop_moves[replicated] -> Flaky test_multiple_disks #45404
• Mergeable Check -> No idea. Can't see
• Stateless tests (tsan, s3 storage) [4/5] — fail: 2, passed: 1013, skipped: 21
  02481_parquet_list_monotonically_increasing_offsets timeout
  01605_adaptive_granularity_block_borders timeout -> 01605_adaptive_granularity_block_borders is flaky #50681

[Algunenano]

PR is clean and ready for review. Updating with master for the sake of keeping it close to HEAD

[Algunenano]

Failure in unrelated test -> #52059

[alexey-milovidov]

Flush queries for async inserts (the queries that do the final push of data) are not logged

"are not logged" -> are now logged.

[alexey-milovidov]

I've asked @CurtizJ to review.

[lesandie]

This is a nice add @Algunenano thanks for this!. Am I right into assuming this cannot be backported to LTS 23.3?

because until this PR it was difficult to have some introspection on async_inserts apart from the asynchronous_insert_log:

• There is no way to relate part_log with asynchronous_insert_log query_id/flush_query_id you need to go to query_log
• Table async_insert_log shows up the query_id and flush_query_id of each async insert.
• query_id from asynchronous_insert_log shows up in the system.query_log as type = 'QueryStart' but the same
• query_id does not show up in the query_id column of the system.part_log.
• The query_id column in the part_log is the identifier of the INSERT query that created a data part, and it seems it is for sync INSERTS but not for asyncs.

[Algunenano]

Am I right into assuming this cannot be backported to LTS 23.3?

Impossible is nothing, but yes, features aren't backported.

The query_id column in the part_log is the identifier of the INSERT query that created a data part, and it seems it is for sync INSERTS but not for asyncs.

This one is a bug but it should be easily fixable. I'll send the fix.