Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use read_bytes/total_bytes_to_read for progress bar in s3/file/url/... table functions #51286

Merged
merged 16 commits into from Jul 26, 2023

Conversation

Avogar
Copy link
Member

@Avogar Avogar commented Jun 22, 2023

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Use read_bytes/total_bytes_to_read for progress bar in s3/file/url/... table functions for better progress indication.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-improvement Pull request with some product improvements label Jun 22, 2023
@robot-clickhouse-ci-1
Copy link
Contributor

robot-clickhouse-ci-1 commented Jun 22, 2023

This is an automated comment for commit 15cc046 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟡 pending

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
Mergeable CheckChecks if all other necessary checks are successful🟢 success

@Avogar Avogar marked this pull request as draft June 23, 2023 08:08
@Avogar Avogar marked this pull request as ready for review July 24, 2023 18:00
@vdimir vdimir self-assigned this Jul 25, 2023
@Avogar Avogar merged commit a875cf5 into ClickHouse:master Jul 26, 2023
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants