Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ALTER TABLE MODIFY COMMENT #51304

Merged
merged 9 commits into from Sep 7, 2023

Conversation

alexey-milovidov
Copy link
Member

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add support for ALTER TABLE MODIFY COMMENT. Note: something similar was added by an external contributor a long time ago, but the feature did not work at all and only confused users. This closes #36377.

@robot-ch-test-poll robot-ch-test-poll added the pr-feature Pull request with new product feature label Jun 23, 2023
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented Jun 23, 2023

This is an automated comment for commit ce8ab5c with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟡 pending

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
Mergeable CheckChecks if all other necessary checks are successful🟢 success

@alesapin alesapin self-assigned this Jun 23, 2023
@alesapin
Copy link
Member

alesapin commented Sep 5, 2023

I'm still here, will fix

@alexey-milovidov
Copy link
Member Author

Wow, it's green!

@alexey-milovidov alexey-milovidov merged commit 1b30f91 into master Sep 7, 2023
3 of 5 checks passed
@alexey-milovidov alexey-milovidov deleted the alter-table-add-comment branch September 7, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ALTER TABLE MODIFY COMMENT does not work on ReplicatedMergeTree
3 participants