fix storage policy prompt display error #51519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
src/Disks/StoragePolicy.cpp
Outdated
| @@ -302,15 +302,15 @@ void StoragePolicy::checkCompatibleWith(const StoragePolicyPtr & new_storage_pol | |||
| for (const auto & volume : getVolumes()) | |||
| { | |||
| if (!new_volume_names.contains(volume->getName())) | |||
| throw Exception(ErrorCodes::BAD_ARGUMENTS, "New storage policy {} shall contain volumes of old one", backQuote(name)); | |||
| throw Exception(ErrorCodes::BAD_ARGUMENTS, "New storage policy {} shall contain volumes of old one", backQuote(new_storage_policy->getName())); | |||
There was a problem hiding this comment.
Let's print both names, new and old.
There was a problem hiding this comment.
good idea, I've got it
alexey-milovidov
added
the
can be tested
robot-ch-test-poll3
added
the
pr-improvement
|
This is an automated comment for commit 5f523e8 with description of existing statuses. It's updated for the latest CI running
|
alexey-milovidov
approved these changes
Jun 28, 2023
This comment was marked as abuse.
This comment was marked as abuse.
|
Wait while it is fixed, or try to figure it out on your own. |
OK，thanks for your reply |
|
@alexey-milovidov @evillique Hello，Please help me merge this PR，thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
correcting the message of modify storage policy #51516
Documentation entry for user-facing changes