New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add system sync filesystem cache
command
#51622
Conversation
This is an automated comment for commit c8a12f7 with description of existing statuses. It's updated for the latest CI running
|
9b53e81
to
c8ab68a
Compare
a41a07f
to
0c03b16
Compare
809327e
to
2b02148
Compare
FileSegments getSnapshot(); | ||
|
||
FileSegmentsHolderPtr getSnapshot(const Key & key); | ||
FileSegments getSnapshot(const Key & key); | ||
|
||
FileSegmentsHolderPtr dumpQueue(); | ||
FileSegments dumpQueue(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it okay to make a copy of the entire list? At first glance, seems expensive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dumpQueue
is used for unit test only, and getSnapthot
is only for system tables. Also afaik the the result is moved and not copied as the function returns a local variable.
The tests in this pr fail because of revert of #52778. |
|
test_storage_rabbitmq |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add
SYSTEM SYNC FILESYSTEM CACHE
command. It will compare in-memory state of filesystem cache with what it has on disk and fix in-memory state if needed.