New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New initcap / initcapUTF8 functions (Capital/Title Case) #51735
Conversation
This is an automated comment for commit 6d7e985 with description of existing statuses. It's updated for the latest CI running
|
@@ -0,0 +1,66 @@ | |||
#include <Functions/FunctionFactory.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically I copied from LowerUpperImpl.h and LowerUpperUTF8Impl.h
@vdimir Passed the tests. Is there anything else i need to do? |
@kardymonds I went trough the PR, and it looks good. I'll read the code once more a bit deeper soon, and will leave the comments if any. But I suppose it will be none or maybe only minor ones. Thank you for the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the feature!
Close #45217
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added new initcap / initcapUTF8 functions which convert the first letter of each word to upper case and the rest to lower case.
Documentation entry for user-facing changes