Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting max_execution_time_leaf to limit the execution time on shard for distributed query #51823

Merged
merged 9 commits into from Nov 3, 2023

Conversation

canhld94
Copy link
Contributor

@canhld94 canhld94 commented Jul 5, 2023

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add a setting max_execution_time_leaf to limit the execution time on shard for distributed query, and timeout_overflow_mode_leaf to control the behaviour if timeout happens.

Close #46102

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@canhld94
Copy link
Contributor Author

canhld94 commented Jul 5, 2023

@alexey-milovidov @ucasfl can we consider adding this settings? I think it's also reasonable to have this settings when we only want to limit the execution time on remote shard, not on coordinator.

@robot-ch-test-poll robot-ch-test-poll added the pr-improvement Pull request with some product improvements label Jul 17, 2023
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented Jul 17, 2023

This is an automated comment for commit dd6b02a with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs CheckBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Nov 1, 2023
@alexey-milovidov
Copy link
Member

Sorry, we forgot about this pull request - we will pick it up.

@alexey-milovidov alexey-milovidov self-assigned this Nov 1, 2023
@alexey-milovidov alexey-milovidov removed their assignment Nov 1, 2023
@alexey-milovidov
Copy link
Member

@canhld94 I've resolved conflicts and fixed typos, but more changes are needed.

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
@Avogar Avogar self-assigned this Nov 2, 2023
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
@Avogar Avogar merged commit 81b1ca2 into ClickHouse:master Nov 3, 2023
280 of 282 checks passed
@tavplubix
Copy link
Member

Failed tests were related. It breaks test 02896_memory_accounting_for_user, so I have to revert it. See #56685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add max_execution_time_leaf
6 participants