New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move conditions with columns from PK to the end of PREWHERE chain #51958
Conversation
This is an automated comment for commit 0c2ea94 with description of existing statuses. It's updated for the latest CI running
|
278b1e9
to
9341483
Compare
6f77a88
to
4e8221a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but I'd love to see a benchmark over a real table (at least ClickBench run)
@nickitat here are ClickBench results https://pastila.nl/?000b1ba6/c2b445d46b4b7e269b0be94efcf97c7f.html |
33c45ed
to
83e7679
Compare
yep |
83e7679
to
0c2ea94
Compare
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
The idea is that conditions with PK columns are likely to be used in PK analysis and will not contribute much more to PREWHERE filtering