New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watch for certificate files updates in ConfigReloader #52030
Watch for certificate files updates in ConfigReloader #52030
Conversation
This is an automated comment for commit d0f81fb with description of existing statuses. It's updated for the latest CI running
|
Things to consider: path to certificate changed, needs updating from inside the reloader itself. |
Another (better option) -- run an update callback on configReloader creation having lvalue ref to the reloader, and move certificateReloader inside configReloader callbacks everywhere. Will update PR tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
It does not have a test. Let's proceed without a test (but you agree that the feature can be broken or removed)
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Update certificates when they change without the need to manually SYSTEM RELOAD CONFIG