Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaterializedMySQL: Introduce charset conversion #52084

Merged
merged 2 commits into from
Jul 23, 2023

Conversation

valbok
Copy link
Contributor

@valbok valbok commented Jul 13, 2023

Converts MYSQL_TYPE_VARCHAR, MYSQL_TYPE_VAR_STRING, MYSQL_TYPE_STRING and MYSQL_TYPE_BLOB types to utf-8 if needed on incremental replication.

Makes sure that replicated data is always valid, see tests.

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Introduced automatic conversion of text types to utf8 for MaterializedMySQL

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@valbok valbok force-pushed the conv-charsets branch 2 times, most recently from 1691824 to 129ae19 Compare July 13, 2023 12:46
@valbok valbok marked this pull request as draft July 13, 2023 13:22
@valbok valbok marked this pull request as ready for review July 13, 2023 13:48
@CLAassistant
Copy link

CLAassistant commented Jul 13, 2023

CLA assistant check
All committers have signed the CLA.

@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Jul 14, 2023
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-improvement Pull request with some product improvements label Jul 14, 2023
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Jul 14, 2023

This is an automated comment for commit c4f9b3a with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟢 success

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@valbok valbok marked this pull request as draft July 16, 2023 12:48
@valbok valbok marked this pull request as ready for review July 17, 2023 09:34
@valbok valbok marked this pull request as draft July 17, 2023 09:57
@valbok valbok force-pushed the conv-charsets branch 4 times, most recently from 74bdf56 to 3f16f61 Compare July 17, 2023 11:12
@valbok valbok marked this pull request as ready for review July 17, 2023 13:48
@valbok
Copy link
Contributor Author

valbok commented Jul 19, 2023

@alexey-milovidov any comments here?

@valbok
Copy link
Contributor Author

valbok commented Jul 21, 2023

@kssenii

@kssenii kssenii self-assigned this Jul 21, 2023
@robot-ch-test-poll4 robot-ch-test-poll4 merged commit 1d6e85d into ClickHouse:master Jul 23, 2023
272 checks passed
@valbok valbok deleted the conv-charsets branch July 23, 2023 16:43
@valbok
Copy link
Contributor Author

valbok commented Jul 24, 2023

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants