Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a pass in Analyzer for time filter optimization with preimage #52091

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Add a pass in Analyzer for time filter optimization with preimage #52091

merged 3 commits into from
Aug 1, 2023

Commits on Jul 24, 2023

  1. Rename: extend the tests to QueryTree validation

    @ZhiguoZh
    ZhiguoZh committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    eb8e7f4 View commit details
    Browse the repository at this point in the history

  2. Add a pass in Analyzer for time filter optimization with preimage 

    The preimage has been identified as the general solution to the
optimization of predicates with time converters (ClickHouse#15257). PR ClickHouse#50951
implemented this solution via the AST rewrite.

As a follow-up, this commit extends the optimization to the experi-
mental analyzer by replacing the sub-QueryTree of the time filter
with its preimage-transformed one. The optimization is implemented
as a new pass in the Analyzer.
    @ZhiguoZh
    ZhiguoZh committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    b88fc42 View commit details
    Browse the repository at this point in the history

  3. Enforce type check for function arguments in preimage optimization 

    Date/Date32/DateTime/DateTime64 columns are required for arguments
of time converters, such as toYear and toYYYYMM.
    @ZhiguoZh
    ZhiguoZh committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    9ff409f View commit details
    Browse the repository at this point in the history