Add SQLTest #52293

alexey-milovidov · 2023-07-19T01:43:22Z

Changelog category (leave one):

Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add https://github.com/elliotchance/sqltest to CI to report the SQL 2016 conformance.

robot-ch-test-poll2 · 2023-07-19T01:44:41Z

This is an automated comment for commit 561e043 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	🟢 success
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	🟢 success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	🟢 success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	🟢 success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	🟢 success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	🟢 success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	🟢 success
Install packages	Checks that the built packages are installable in a clear environment	🟢 success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	🔴 failure
Mergeable Check	Checks if all other necessary checks are successful	🟢 success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	🟢 success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	🟢 success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	🟢 success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	🟢 success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	🟢 success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	🟢 success
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	🟢 success
Unit tests	Runs the unit tests for different release types	🟢 success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	🟢 success

docker/images.json

tests/ci/tests/docker_images.json

Felixoid · 2023-07-21T09:34:42Z

docker/test/sqltest/run.sh

+set -u
+set -o pipefail
+
+BINARY_TO_DOWNLOAD=${BINARY_TO_DOWNLOAD:="clang-16_debug_none_unsplitted_disable_False_binary"}


Please, don't use the worst practices from performance tests. Binaries should be downloaded in advance and mounted into the container by a script from tests/ci

Ok. I use copy-paste and ChatGPT to write Python. And when I'm using copy-paste, I'm trying to reuse the shortest code, so I have less amount to read.

Felixoid · 2023-07-21T09:36:25Z

tests/ci/sqltest.py

+
+    run_log_path = os.path.join(temp_path, "run.log")
+    with open(run_log_path, "w", encoding="utf-8") as log:
+        with subprocess.Popen(


TeePopen looks like a better class here

Felixoid · 2023-07-21T09:37:26Z

tests/ci/sqltest.py

+    s3_prefix = f"{pr_info.number}/{pr_info.sha}/sqltest_{check_name_lower}/"
+    paths = {
+        "run.log": run_log_path,
+        "main.log": os.path.join(workspace_path, "main.log"),


just a side note, py3 has pathlib.Path class. It's much nicer in usage than the old os.path things

Felixoid · 2023-07-21T09:38:05Z

tests/ci/sqltest.py

+    s3_helper = S3Helper()
+    for f in paths:
+        try:
+            paths[f] = s3_helper.upload_test_report_to_s3(paths[f], s3_prefix + f)


by adding logs to TestResult you can skip this part

Felixoid · 2023-07-21T09:38:55Z

tests/ci/sqltest.py

+
+    status = "success"
+    description = "See the report"
+    test_result = TestResult(description, "OK")


add logs and report files here

Ok. I want to make a small working prototype first.
This check has limited use. It should exist; everything else we will address later (or never).

alexey-milovidov · 2023-07-21T23:52:39Z

@Felixoid currently it does not work due to

FAIL: test_get_changed_docker_images (docker_test.TestDockerImageCheck)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ubuntu/actions-runner/_work/ClickHouse/ClickHouse/tests/ci/docker_test.py", line 99, in test_get_changed_docker_images
    self.assertEqual(images, expected)
AssertionError: Lists differ: [Dock[675 chars]est/sqltest,repo=clickhouse/sqltest,parent=cli[410 chars]est)] != [Dock[675 chars]est/stateful,repo=clickhouse/stateful-test,par[319 chars]est)]

First differing element 7:
Docke[20 chars]est/sqltest,repo=clickhouse/sqltest,parent=cli[13 chars]base)
Docke[20 chars]est/stateful,repo=clickhouse/stateful-test,par[25 chars]test)

First list contains 1 additional elements.
First extra element 11:
DockerImage(path=docker/test/unit,repo=clickhouse/unit-test,parent=clickhouse/stateless-test)

  [DockerImage(path=docker/docs/builder,repo=clickhouse/docs-builder,parent=None),
   DockerImage(path=docker/test/base,repo=clickhouse/test-base,parent=None),
   DockerImage(path=docker/docs/check,repo=clickhouse/docs-check,parent=clickhouse/docs-builder),
   DockerImage(path=docker/docs/release,repo=clickhouse/docs-release,parent=clickhouse/docs-builder),
   DockerImage(path=docker/test/fuzzer,repo=clickhouse/fuzzer,parent=clickhouse/test-base),
   DockerImage(path=docker/test/integration/base,repo=clickhouse/integration-test,parent=clickhouse/test-base),
   DockerImage(path=docker/test/keeper-jepsen,repo=clickhouse/keeper-jepsen-test,parent=clickhouse/test-base),
-  DockerImage(path=docker/test/sqltest,repo=clickhouse/sqltest,parent=clickhouse/test-base),
   DockerImage(path=docker/test/stateful,repo=clickhouse/stateful-test,parent=clickhouse/stateless-test),
   DockerImage(path=docker/test/stateless,repo=clickhouse/stateless-test,parent=clickhouse/test-base),
   DockerImage(path=docker/test/stress,repo=clickhouse/stress-test,parent=clickhouse/stateful-test),
   DockerImage(path=docker/test/unit,repo=clickhouse/unit-test,parent=clickhouse/stateless-test)]

alexey-milovidov · 2023-07-21T23:58:06Z

What is the difference between images.json and docker_images.json?
They look almost identical, but not quite. And JSON does not support comments, unfortunately.

alexey-milovidov · 2023-07-22T15:35:27Z

I found something strange, but didn't understand it: #33751

alexey-milovidov · 2023-07-22T17:11:59Z

@Felixoid Now it is complete ..F.........

First differing element 7:
Docke[21 chars]st/sqltest,repo=clickhouse/sqltest,parent=clickhouse/test-base)
Docke[21 chars]st/sqltest,repo=clickhouse/sqltest,parent=clickhouse/test-base)

Felixoid · 2023-08-01T08:56:11Z

You shouldn't have used True for only_amd64

.github/workflows/pull_request.yml

alexey-milovidov · 2023-08-10T18:47:54Z

I thought Azure test was fixed...

Add SQLTest

8e3bd22

robot-ch-test-poll2 added the pr-build Pull request with build/testing/packaging improvement label Jul 19, 2023

alexey-milovidov and others added 9 commits July 19, 2023 03:45

Update Docker

df5abcf

Fix error

174166b

Fix error

fcf4a6e

Improvement

2255307

Improvement

50dac21

Improvement

76677e0

Improvement

fe59729

Improvement

9b10e0a

Automatic style fix

891c01e

Felixoid reviewed Jul 19, 2023

View reviewed changes

docker/images.json Show resolved Hide resolved

Felixoid reviewed Jul 19, 2023

View reviewed changes

tests/ci/tests/docker_images.json Outdated Show resolved Hide resolved

alexey-milovidov added 6 commits July 19, 2023 19:58

Merge branch 'master' of github.com:ClickHouse/ClickHouse into sqltest

f7fcf07

Fix Docker

29094a2

Merge branch 'sqltest' of github.com:ClickHouse/ClickHouse into sqltest

3c2fe6e

Fix style

f458108

Fix style

fa44f84

Merge branch 'master' into sqltest

de52a13

Felixoid requested changes Jul 21, 2023

View reviewed changes

Felixoid self-assigned this Jul 21, 2023

Merge branch 'master' into sqltest

999cce1

alexey-milovidov added 3 commits July 22, 2023 02:04

Add something with unclear purpose

3398355

Merge branch 'sqltest' of github.com:ClickHouse/ClickHouse into sqltest

81fc154

Do something

c3c8ea9

alexey-milovidov and others added 6 commits August 1, 2023 17:05

Update docker_test.py

8646eef

Merge branch 'master' into sqltest

0931e87

Merge branch 'master' into sqltest

f87e53c

Merge branch 'master' into sqltest

97bd68d

Add missing modification

0641dfd

Merge branch 'sqltest' of github.com:ClickHouse/ClickHouse into sqltest

3b6247e

alexey-milovidov mentioned this pull request Aug 2, 2023

Refactor CI_CONFIG #52948

Merged

Felixoid reviewed Aug 2, 2023

View reviewed changes

.github/workflows/pull_request.yml Outdated Show resolved Hide resolved

alexey-milovidov and others added 15 commits August 2, 2023 21:05

Update pull_request.yml

b4f0d0b

Merge branch 'master' into sqltest

a98e869

Merge branch 'master' into sqltest

a936da5

Fix log paths

5ec6a46

Automatic style fix

619af0c

Merge branch 'master' into sqltest

2c08595

Fix paths

65e8ee8

Merge branch 'sqltest' of github.com:ClickHouse/ClickHouse into sqltest

1679ae4

Automatic style fix

a96b045

Fix paths

388feb9

Merge branch 'sqltest' of github.com:ClickHouse/ClickHouse into sqltest

2f0b8f0

Merge branch 'master' into sqltest

580f207

Merge branch 'master' into sqltest

b0763d1

Merge branch 'master' into sqltest

ede1b17

Merge branch 'master' into sqltest

5315161

Merge branch 'master' into sqltest

561e043

alexey-milovidov merged commit d059465 into master Aug 12, 2023
273 of 275 checks passed

alexey-milovidov deleted the sqltest branch August 12, 2023 21:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add SQLTest #52293

Add SQLTest #52293

alexey-milovidov commented Jul 19, 2023

robot-ch-test-poll2 commented Jul 19, 2023 •

edited by robot-clickhouse-ci-1

Felixoid Jul 21, 2023

alexey-milovidov Jul 21, 2023

Felixoid Jul 21, 2023

Felixoid Jul 21, 2023

Felixoid Jul 21, 2023 •

edited

Felixoid Jul 21, 2023

alexey-milovidov Aug 12, 2023

alexey-milovidov commented Jul 21, 2023

alexey-milovidov commented Jul 21, 2023

alexey-milovidov commented Jul 22, 2023

alexey-milovidov commented Jul 22, 2023

Felixoid commented Aug 1, 2023

alexey-milovidov commented Aug 10, 2023

Add SQLTest #52293

Add SQLTest #52293

Conversation

alexey-milovidov commented Jul 19, 2023

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

robot-ch-test-poll2 commented Jul 19, 2023 • edited by robot-clickhouse-ci-1

Felixoid Jul 21, 2023

Choose a reason for hiding this comment

alexey-milovidov Jul 21, 2023

Choose a reason for hiding this comment

Felixoid Jul 21, 2023

Choose a reason for hiding this comment

Felixoid Jul 21, 2023

Choose a reason for hiding this comment

Felixoid Jul 21, 2023 • edited

Choose a reason for hiding this comment

Felixoid Jul 21, 2023

Choose a reason for hiding this comment

alexey-milovidov Aug 12, 2023

Choose a reason for hiding this comment

alexey-milovidov commented Jul 21, 2023

alexey-milovidov commented Jul 21, 2023

alexey-milovidov commented Jul 22, 2023

alexey-milovidov commented Jul 22, 2023

Felixoid commented Aug 1, 2023

alexey-milovidov commented Aug 10, 2023

robot-ch-test-poll2 commented Jul 19, 2023 •

edited by robot-clickhouse-ci-1

Felixoid Jul 21, 2023 •

edited