Fix S3 table function does not work for pre-signed URL

[xiedeyantu]

Changelog category (leave one):

• Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix S3 table function does not work for pre-signed URL. close #50846

Documentation entry for user-facing changes

• Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

[robot-ch-test-poll]

This is an automated comment for commit 0c3118c with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	🟢 success
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	🟢 success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	🟢 success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	🟢 success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	🟢 success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	🟢 success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	🟢 success
Install packages	Checks that the built packages are installable in a clear environment	🟢 success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	🟢 success
Mergeable Check	Checks if all other necessary checks are successful	🟢 success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	🟢 success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	🟢 success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	🟢 success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	🟢 success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	🔴 failure
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	🟢 success
Unit tests	Runs the unit tests for different release types	🟢 success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	🟢 success

[xiedeyantu]

@Avogar please review this pr.

[nikitamikhaylov]

What is the idea? Did you test it?

[xiedeyantu]

What is the idea? Did you test it?

@nikitamikhaylov file_extension will return a string with a question mark, just extract the extension before the question mark. I have do the test, but aarch64 platform can not support to run integration test, there is a problem with the docker image. So I can not add integration test now.

[Avogar]

Actually, getFormatFromFileName supposed to process path without query after ? from url. Here we extract path from URL:

ClickHouse/src/TableFunctions/TableFunctionS3.cpp

Line 184 in e133db7

configuration.format = FormatFactory::instance().getFormatFromFileName(configuration.url.uri.getPath(), true);

But we can encode the ? symbol in s3 url:

ClickHouse/src/IO/S3/URI.cpp

Lines 59 to 64 in e133db7

	if (!has_version_id && uri_.find('?') != String::npos)
	{
	String uri_with_question_mark_encode;
	Poco::URI::encode(uri_, "?", uri_with_question_mark_encode);
	uri = Poco::URI(uri_with_question_mark_encode);
	}

So, getPath() will return path with query part in this case. To avoid it, we can just replace
getFormatFromFileName(configuration.url.uri.getPath()) to smth like getFormatFromFileName(Poco::URI(configuration.url.uri.getPath()).getPath() to eliminate query part of the url. So, no need to modify getFormatFromFileName function