New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load suggestion only with clickhouse
dialect
#52628
Merged
alexey-milovidov
merged 3 commits into
master
from
load-suggestion-only-with-clickhouse-dialect
Jul 28, 2023
Merged
Load suggestion only with clickhouse
dialect
#52628
alexey-milovidov
merged 3 commits into
master
from
load-suggestion-only-with-clickhouse-dialect
Jul 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antaljanosbenjamin
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Jul 26, 2023
This is an automated comment for commit ac51ade with description of existing statuses. It's updated for the latest CI running
|
antonio2368
reviewed
Jul 27, 2023
antonio2368
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay
alexey-milovidov
deleted the
load-suggestion-only-with-clickhouse-dialect
branch
July 28, 2023 07:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created-cloud
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport-cloud
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Do not try to load suggestions in
clickhouse-local
when a the dialect is notclickhouse
.Documentation entry for user-facing changes
If we try to load the suggestions for example when
clickhouse-local
is started with PRQL dialect, user gets an ugly error message: