Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test_reconfig_replace_leader_in_one_command #52901

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

antonio2368
Copy link
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Test will be disabled until @myrrc pushes a proper fix we discussed.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 2, 2023
@robot-clickhouse-ci-1
Copy link
Contributor

robot-clickhouse-ci-1 commented Aug 2, 2023

This is an automated comment for commit c175235 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟡 pending

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success

@antonio2368 antonio2368 merged commit 61ae079 into master Aug 2, 2023
9 of 11 checks passed
@antonio2368 antonio2368 deleted the disable-test-keeper-reconfig branch August 2, 2023 06:45
@myrrc
Copy link
Contributor

myrrc commented Aug 16, 2023

The example follows:

  1. Cluster [1 2 3], 1 is leader
  2. Issue "add 4, remove 1" from node 2 as a single command.
  3. [1] accepts "add 4" but doesn't commit it
  4. [1] accepts "remove 1" (yield_leadership part), steps down
  5. "add 4" is lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants