Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCD codec #53149

Merged
merged 95 commits into from Sep 5, 2023
Merged

Add GCD codec #53149

merged 95 commits into from Sep 5, 2023

Conversation

seshWCS
Copy link
Contributor

@seshWCS seshWCS commented Aug 8, 2023

Fixes: #48349

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added "GCD" aka. "greatest common denominator" as a new data compression codec. The codec computes the GCD of all column values, and then divides each value by the GCD. The GCD codec is a data preparation codec (similar to Delta and DoubleDelta) and cannot be used stand-alone. It works with data integer, decimal and date/time type. A viable use case for the GCD codec are column values that change (increase/decrease) in multiples of the GCD, e.g. 24 - 28 - 16 - 24 - 8 - 24 (assuming GCD = 4).

@CLAassistant
Copy link

CLAassistant commented Aug 8, 2023

CLA assistant check
All committers have signed the CLA.

@seshWCS seshWCS marked this pull request as draft August 8, 2023 08:11
@nickitat nickitat self-assigned this Aug 8, 2023
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-feature Pull request with new product feature label Aug 8, 2023
@robot-ch-test-poll3
Copy link
Contributor

robot-ch-test-poll3 commented Aug 8, 2023

This is an automated comment for commit d416aaf with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Docs CheckBuilds and tests the documentation🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 failure
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@nickitat nickitat added the can be tested Allows running workflows for external contributors label Aug 8, 2023
@alexey-milovidov
Copy link
Member

Let's add tests.

@seshWCS seshWCS marked this pull request as ready for review August 11, 2023 13:23
@seshWCS
Copy link
Contributor Author

seshWCS commented Sep 3, 2023

GCD + LZ4 with UInt64:

0 rows in set. Elapsed: 11.981 sec. Processed 200.25 million rows, 1.60 GB (16.71 million rows/s., 133.72 MB/s.)
Peak memory usage: 25.59 MiB.

LZ4 with UInt64:

0 rows in set. Elapsed: 9.799 sec. Processed 200.25 million rows, 1.60 GB (20.44 million rows/s., 163.50 MB/s.)
Peak memory usage: 25.62 MiB.

@seshWCS
Copy link
Contributor Author

seshWCS commented Sep 4, 2023

@nickitat review plz :)

@rschu1ze rschu1ze self-assigned this Sep 5, 2023
@rschu1ze rschu1ze changed the title GCD codec Add GCD codec Sep 5, 2023
src/Compression/CompressionCodecGCD.cpp Outdated Show resolved Hide resolved
src/Compression/CompressionCodecGCD.cpp Show resolved Hide resolved
src/Compression/CompressionCodecGCD.cpp Outdated Show resolved Hide resolved
src/Compression/CompressionCodecGCD.cpp Outdated Show resolved Hide resolved
src/Compression/CompressionCodecGCD.cpp Outdated Show resolved Hide resolved
src/Compression/CompressionCodecGCD.cpp Outdated Show resolved Hide resolved
src/Compression/CompressionCodecGCD.cpp Outdated Show resolved Hide resolved
src/Compression/CompressionFactory.cpp Show resolved Hide resolved
src/Compression/CompressionFactory.cpp Outdated Show resolved Hide resolved
@rschu1ze rschu1ze merged commit 470ce34 into ClickHouse:master Sep 5, 2023
276 of 282 checks passed
rschu1ze added a commit to rschu1ze/ClickHouse that referenced this pull request Sep 5, 2023
robot-clickhouse added a commit that referenced this pull request Sep 7, 2023
Consolidate GCD codec tests (Follow up to #53149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Greatest Common Divisor codec
6 participants