New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better usage of ccache #53184
Better usage of ccache #53184
Conversation
@@ -8,7 +8,6 @@ const char * auto_config_build[] | |||
"SYSTEM", "@CMAKE_SYSTEM_NAME@", | |||
"VERSION_GITHASH", "@VERSION_GITHASH@", | |||
"VERSION_REVISION", "@VERSION_REVISION@", | |||
"VERSION_DATE", "@VERSION_DATE@", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field was not used (obsolete).
|
||
#if defined(VERSION_MAJOR) | ||
#define DBMS_VERSION_MAJOR VERSION_MAJOR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was redundant.
#define DBMS_VERSION_PATCH 0 | ||
#endif | ||
/// These fields are frequently changing and we don't want to have them in the header file to allow caching. | ||
extern const char * VERSION_GITHASH; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The culprit is here.
This is an automated comment for commit f35df23 with description of existing statuses. It's updated for the latest CI running
|
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Some translation units were always rebuilt regardless of ccache. The culprit is found and fixed.