Fix IO throttling during copying whole directories #53338

azat · 2023-08-11T15:53:09Z

Changelog category (leave one):

Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix IO throttling during copying whole directories (MOVE PARTITION TO VOLUME, fetching/cloning parts, mutations, ...)

P.S. help with tests is highly appreciated (for now I've tested only locally MOVE PARTITION TO VOLUME)

Fixes: #52753 (cc @den-crane)
Fixes: #52183 (cc @coulsonm)

robot-ch-test-poll1 · 2023-08-11T15:53:40Z

This is an automated comment for commit aaa68a5 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟢 success

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	🟢 success
Bugfix validate check	Checks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch	🟢 success
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	🟢 success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	🟢 success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	🟢 success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	🟢 success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	🟢 success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	🟢 success
Install packages	Checks that the built packages are installable in a clear environment	🟢 success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	🟢 success
Mergeable Check	Checks if all other necessary checks are successful	🟢 success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	🟢 success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	🟢 success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	🟢 success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	🟢 success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	🟢 success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	🟢 success
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	🟢 success
Unit tests	Runs the unit tests for different release types	🟢 success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	🟢 success

coulsonm · 2023-08-17T09:54:31Z

FileNotFoundError: [Errno 2] No such file or directory: '/home/ubuntu/actions-runner/_work/_temp/tests_bugfix_check/integration/integration_commit_status.tsv'

coulsonm · 2023-08-18T02:58:40Z

@azat

azat · 2023-08-18T14:41:34Z

This is likely internal CI issue. And this PR does not have a test yet.

coulsonm · 2023-08-23T06:24:40Z

May I ask when will it be repaired? @azat

azat · 2023-08-27T06:16:10Z

This should not be required for merging this PR, it just needs some attention. @serxa maybe you can take a look?

serxa

Looks good. As for tests, at least a simple check for the duration of explicit ALTER TABLE MOVE PARTITION would be good enough.

src/Disks/ObjectStorages/DiskObjectStorageTransaction.cpp

v2: pass local context during ALTER TABLE MOVE PARTITION TO VOLUME/DISK as well Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

azat · 2023-08-29T21:15:10Z

As for tests, at least a simple check for the duration of explicit ALTER TABLE MOVE PARTITION would be good enough.

Yeah, I was just lazy and thought maybe someone will contribute the test in the mean time, but this did not happen, so I've added the test.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

…ttling ALTER TABLE MOVE PARTITION TO DISK/VOLUME should not be replicated since replicas will not contains this part: azat:~/ch/tmp/53338$ for i in clickhouse-server*.log.zst; do echo -n "$i: " && zstd -cdq $i | grep -m1 -e Executed.*ALTER.*test_cnmf4xnb.test_move_partition_throttling -e Exception.*ALTER.*test_cnmf4xnb.test_move_partition_throttling; done clickhouse-server1.log.zst: 2023.08.29 16:46:53.960065 [ 1843 ] {19b13d67-54c0-496d-96b9-b1ec09df3618} <Error> executeQuery: Code: 232. DB::Exception: Nothing to move (check that the partition exists). (NO_SUCH_DATA_PART) (version 23.8.1.2862) (from 0.0.0.0:0) (comment: 02870_move_partition_to_volume_io_throttling.sql) (in query: /* ddl_entry=query-0000000005 */ ALTER TABLE test_cnmf4xnb.test_move_partition_throttling MOVE PARTITION tuple() TO VOLUME 'remote' SETTINGS max_remote_write_network_bandwidth = 1600000), Stack trace (when copying this message, always include the lines below): clickhouse-server2.log.zst: 2023.08.29 16:46:53.959560 [ 1842 ] {3cd2b5e8-24b9-4cfd-aa47-854e634936f2} <Error> executeQuery: Code: 232. DB::Exception: Nothing to move (check that the partition exists). (NO_SUCH_DATA_PART) (version 23.8.1.2862) (from 0.0.0.0:0) (comment: 02870_move_partition_to_volume_io_throttling.sql) (in query: /* ddl_entry=query-0000000005 */ ALTER TABLE test_cnmf4xnb.test_move_partition_throttling MOVE PARTITION tuple() TO VOLUME 'remote' SETTINGS max_remote_write_network_bandwidth = 1600000), Stack trace (when copying this message, always include the lines below): clickhouse-server.log.zst: 2023.08.29 16:46:53.950730 [ 721 ] {df6b20ee-1903-404a-9398-7fead209ccd7} <Debug> DDLWorker(test_cnmf4xnb): Executed query: /* ddl_entry=query-0000000005 */ ALTER TABLE test_cnmf4xnb.test_move_partition_throttling MOVE PARTITION tuple() TO VOLUME 'remote' SETTINGS max_remote_write_network_bandwidth = 1600000 CI: https://s3.amazonaws.com/clickhouse-test-reports/53338/ed401cba9b8254b4a29a5ed9e5ad838c26ffaac1/stateless_tests__release__databasereplicated__[4_4].html Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

robot-ch-test-poll1 added the pr-bugfix Pull request with bugfix, not backported by default label Aug 11, 2023

serxa self-assigned this Aug 28, 2023

serxa approved these changes Aug 28, 2023

View reviewed changes

src/Disks/ObjectStorages/DiskObjectStorageTransaction.cpp Outdated Show resolved Hide resolved

Fix IO throttling during copying whole directories

51e8b16

v2: pass local context during ALTER TABLE MOVE PARTITION TO VOLUME/DISK as well Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

azat force-pushed the throttling-fixes branch from d349988 to 0110258 Compare August 29, 2023 21:14

Add a test for IO throttling for ALTER TABLE MOVE PARTITION TO VOLUME

ed401cb

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

azat force-pushed the throttling-fixes branch from 0110258 to ed401cb Compare August 29, 2023 21:43

azat requested a review from serxa August 30, 2023 08:53

serxa merged commit cf5ea46 into ClickHouse:master Sep 1, 2023
274 checks passed

azat deleted the throttling-fixes branch September 1, 2023 16:35

coulsonm mentioned this pull request Oct 7, 2023

s3 zero copy, some parts can't be removed #55284

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix IO throttling during copying whole directories #53338

Fix IO throttling during copying whole directories #53338

azat commented Aug 11, 2023 •

edited

robot-ch-test-poll1 commented Aug 11, 2023 •

edited by robot-clickhouse-ci-1

coulsonm commented Aug 17, 2023

coulsonm commented Aug 18, 2023

azat commented Aug 18, 2023

coulsonm commented Aug 23, 2023 •

edited

azat commented Aug 27, 2023

serxa left a comment

azat commented Aug 29, 2023

Fix IO throttling during copying whole directories #53338

Fix IO throttling during copying whole directories #53338

Conversation

azat commented Aug 11, 2023 • edited

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

robot-ch-test-poll1 commented Aug 11, 2023 • edited by robot-clickhouse-ci-1

coulsonm commented Aug 17, 2023

coulsonm commented Aug 18, 2023

azat commented Aug 18, 2023

coulsonm commented Aug 23, 2023 • edited

azat commented Aug 27, 2023

serxa left a comment

Choose a reason for hiding this comment

azat commented Aug 29, 2023

azat commented Aug 11, 2023 •

edited

robot-ch-test-poll1 commented Aug 11, 2023 •

edited by robot-clickhouse-ci-1

coulsonm commented Aug 23, 2023 •

edited