Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timeout_overflow_mode when having subquery in the rhs of IN #53439

Merged
merged 4 commits into from Aug 18, 2023
Merged

Fix timeout_overflow_mode when having subquery in the rhs of IN #53439

merged 4 commits into from Aug 18, 2023

Conversation

canhld94
Copy link
Contributor

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Fix timeout_overflow_mode when having subquery in the rhs of IN

Close #53437

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@canhld94
fix timeout_overflow_mode when having subquery in the rhs of IN
8f01c02 
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
@canhld94
Copy link
Contributor Author

cc @KochetovNicolai

@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Aug 15, 2023
@alexey-milovidov alexey-milovidov self-assigned this Aug 15, 2023
@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Aug 15, 2023
@robot-clickhouse
Copy link
Member

robot-clickhouse commented Aug 15, 2023 •
edited

This is an automated comment for commit 506880f with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🔴 failure
Bugfix validate checkChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🔴 failure
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@canhld94
Copy link
Contributor Author 

2023.08.18 12:54:12.337564 [ 490 ] {25ce6fda-7f91-467c-9b1f-d98d93a0e39f} <Fatal> : Logical error: 'Not-ready Set is passed as the second argument for function 'in''.
2023.08.18 12:54:12.337917 [ 571 ] {} <Fatal> BaseDaemon: ########## Short fault info ############
2023.08.18 12:54:12.337940 [ 571 ] {} <Fatal> BaseDaemon: (version 23.8.1.1, build id: A4620D1F49607B4B3FC1337452C687690E67E11B, git hash: a7c27535bfc8655cd9d03adbd1beb725c8776fa4) (from thread 490) Received signal 6
2023.08.18 12:54:12.337948 [ 571 ] {} <Fatal> BaseDaemon: Signal description: Aborted
2023.08.18 12:54:12.337953 [ 571 ] {} <Fatal> BaseDaemon: 
2023.08.18 12:54:12.337966 [ 571 ] {} <Fatal> BaseDaemon: Stack trace: 0x00007f9402b53a7c 0x00007f9402aff476 0x00007f9402ae57f3 0x000055eb1360e7d7 0x000055eb1360f3d5 0x000055eb0796c96b 0x000055eb0cab8678 0x000055eb0796df61 0x000055eb1f9c45e8 0x000055eb1f9c5e27 0x000055eb1f9c7626 0x000055eb2090423e 0x000055eb20901cc3 0x000055eb20904a57 0x000055eb226c58fd 0x000055eb22ce4def 0x000055eb23d7bd65 0x000055eb23d78c7e 0x000055eb23d784c5 0x000055eb23d828c3 0x000055eb23d851a0 0x000055eb23d1fdbb 0x000055eb23d509e1 0x000055eb21569b8b 0x000055eb21ae14c9 0x000055eb21adaafc 0x000055eb233aaec6 0x000055eb233d50d2 0x000055eb2528633e 0x000055eb2528747a 0x000055eb25524e10 0x000055eb2551ff31 0x00007f9402b51b43 0x00007f9402be3a00
2023.08.18 12:54:12.337974 [ 571 ] {} <Fatal> BaseDaemon: ########################################
2023.08.18 12:54:12.337996 [ 571 ] {} <Fatal> BaseDaemon: (version 23.8.1.1, build id: A4620D1F49607B4B3FC1337452C687690E67E11B, git hash: a7c27535bfc8655cd9d03adbd1beb725c8776fa4) (from thread 490) (query_id: 25ce6fda-7f91-467c-9b1f-d98d93a0e39f) (query: SELECT * FROM t PREWHERE value IN (SELECT number FROM numbers(1023)) WHERE 0. IN (SELECT number FROM numbers(2147483647))) Received signal Aborted (6)
2023.08.18 12:54:12.338007 [ 571 ] {} <Fatal> BaseDaemon: 
2023.08.18 12:54:12.338030 [ 571 ] {} <Fatal> BaseDaemon: Stack trace: 0x00007f9402b53a7c 0x00007f9402aff476 0x00007f9402ae57f3 0x000055eb1360e7d7 0x000055eb1360f3d5 0x000055eb0796c96b 0x000055eb0cab8678 0x000055eb0796df61 0x000055eb1f9c45e8 0x000055eb1f9c5e27 0x000055eb1f9c7626 0x000055eb2090423e 0x000055eb20901cc3 0x000055eb20904a57 0x000055eb226c58fd 0x000055eb22ce4def 0x000055eb23d7bd65 0x000055eb23d78c7e 0x000055eb23d784c5 0x000055eb23d828c3 0x000055eb23d851a0 0x000055eb23d1fdbb 0x000055eb23d509e1 0x000055eb21569b8b 0x000055eb21ae14c9 0x000055eb21adaafc 0x000055eb233aaec6 0x000055eb233d50d2 0x000055eb2528633e 0x000055eb2528747a 0x000055eb25524e10 0x000055eb2551ff31 0x00007f9402b51b43 0x00007f9402be3a00
2023.08.18 12:54:12.338046 [ 571 ] {} <Fatal> BaseDaemon: 3. ? @ 0x00007f9402b53a7c in ?
2023.08.18 12:54:12.338055 [ 571 ] {} <Fatal> BaseDaemon: 4. ? @ 0x00007f9402aff476 in ?
2023.08.18 12:54:12.338064 [ 571 ] {} <Fatal> BaseDaemon: 5. ? @ 0x00007f9402ae57f3 in ?
2023.08.18 12:54:12.355333 [ 571 ] {} <Fatal> BaseDaemon: 6. ./build_docker/./src/Common/Exception.cpp:50: DB::abortOnFailedAssertion(String const&) @ 0x00000000293167d7 in /workspace/clickhouse
2023.08.18 12:54:12.371509 [ 571 ] {} <Fatal> BaseDaemon: 7. ./build_docker/./src/Common/Exception.cpp:102: DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x00000000293173d5 in /workspace/clickhouse
2023.08.18 12:54:13.414088 [ 571 ] {} <Fatal> BaseDaemon: 8. DB::Exception::Exception<String>(int, FormatStringHelperImpl<std::type_identity<String>::type>, String&&) @ 0x000000001d67496b in /workspace/clickhouse
2023.08.18 12:54:14.444072 [ 571 ] {} <Fatal> BaseDaemon: 9. DB::(anonymous namespace)::FunctionIn<false, false, true, false>::executeImpl(std::vector<DB::ColumnWithTypeAndName, std::allocator<DB::ColumnWithTypeAndName>> const&, std::shared_ptr<DB::IDataType const> const&, unsigned long) const @ 0x00000000227c0678 in /workspace/clickhouse
2023.08.18 12:54:15.471807 [ 571 ] {} <Fatal> BaseDaemon: 10. DB::FunctionToExecutableFunctionAdaptor::executeImpl(std::vector<DB::ColumnWithTypeAndName, std::allocator<DB::ColumnWithTypeAndName>> const&, std::shared_ptr<DB::IDataType const> const&, unsigned long) const @ 0x000000001d675f61 in /workspace/clickhouse
2023.08.18 12:54:15.482273 [ 571 ] {} <Fatal> BaseDaemon: 11. ./build_docker/./src/Functions/IFunction.cpp:0: DB::IExecutableFunction::executeWithoutLowCardinalityColumns(std::vector<DB::ColumnWithTypeAndName, std::allocator<DB::ColumnWithTypeAndName>> const&, std::shared_ptr<DB::IDataType const> const&, unsigned long, bool) const @ 0x00000000356cc5e8 in /workspace/clickhouse
2023.08.18 12:54:15.493334 [ 571 ] {} <Fatal> BaseDaemon: 12.1. inlined from ./build_docker/./contrib/boost/boost/smart_ptr/intrusive_ptr.hpp:115: intrusive_ptr
2023.08.18 12:54:15.493388 [ 571 ] {} <Fatal> BaseDaemon: 12.2. inlined from ./build_docker/./contrib/boost/boost/smart_ptr/intrusive_ptr.hpp:122: boost::intrusive_ptr<DB::IColumn const>::operator=(boost::intrusive_ptr<DB::IColumn const>&&)
2023.08.18 12:54:15.493401 [ 571 ] {} <Fatal> BaseDaemon: 12.3. inlined from ./build_docker/./src/Common/COW.h:136: COW<DB::IColumn>::immutable_ptr<DB::IColumn>::operator=(COW<DB::IColumn>::immutable_ptr<DB::IColumn>&&)
2023.08.18 12:54:15.493411 [ 571 ] {} <Fatal> BaseDaemon: 12. ./build_docker/./src/Functions/IFunction.cpp:306: DB::IExecutableFunction::executeWithoutSparseColumns(std::vector<DB::ColumnWithTypeAndName, std::allocator<DB::ColumnWithTypeAndName>> const&, std::shared_ptr<DB::IDataType const> const&, unsigned long, bool) const @ 0x00000000356cde27 in /workspace/clickhouse
2023.08.18 12:54:15.504879 [ 571 ] {} <Fatal> BaseDaemon: 13. ./build_docker/./src/Functions/IFunction.cpp:0: DB::IExecutableFunction::execute(std::vector<DB::ColumnWithTypeAndName, std::allocator<DB::ColumnWithTypeAndName>> const&, std::shared_ptr<DB::IDataType const> const&, unsigned long, bool) const @ 0x00000000356cf626 in /workspace/clickhouse
2023.08.18 12:54:15.555606 [ 571 ] {} <Fatal> BaseDaemon: 14.1. inlined from ./build_docker/./contrib/boost/boost/smart_ptr/intrusive_ptr.hpp:115: intrusive_ptr
2023.08.18 12:54:15.555667 [ 571 ] {} <Fatal> BaseDaemon: 14.2. inlined from ./build_docker/./contrib/boost/boost/smart_ptr/intrusive_ptr.hpp:122: boost::intrusive_ptr<DB::IColumn const>::operator=(boost::intrusive_ptr<DB::IColumn const>&&)
2023.08.18 12:54:15.555678 [ 571 ] {} <Fatal> BaseDaemon: 14.3. inlined from ./build_docker/./src/Common/COW.h:136: COW<DB::IColumn>::immutable_ptr<DB::IColumn>::operator=(COW<DB::IColumn>::immutable_ptr<DB::IColumn>&&)
2023.08.18 12:54:15.555689 [ 571 ] {} <Fatal> BaseDaemon: 14. ./build_docker/./src/Interpreters/ExpressionActions.cpp:613: DB::executeAction(DB::ExpressionActions::Action const&, DB::(anonymous namespace)::ExecutionContext&, bool) @ 0x000000003660c23e in /workspace/clickhouse
2023.08.18 12:54:15.596721 [ 571 ] {} <Fatal> BaseDaemon: 15. ./build_docker/./src/Interpreters/ExpressionActions.cpp:0: DB::ExpressionActions::execute(DB::Block&, unsigned long&, bool) const @ 0x0000000036609cc3 in /workspace/clickhouse
2023.08.18 12:54:15.638017 [ 571 ] {} <Fatal> BaseDaemon: 16.1. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/vector:537: std::vector<DB::ColumnWithTypeAndName, std::allocator<DB::ColumnWithTypeAndName>>::size[abi:v15000]() const
2023.08.18 12:54:15.638078 [ 571 ] {} <Fatal> BaseDaemon: 16.2. inlined from ./build_docker/./src/Core/Block.h:106: DB::Block::columns() const
2023.08.18 12:54:15.638090 [ 571 ] {} <Fatal> BaseDaemon: 16.3. inlined from ./build_docker/./src/Core/Block.h:117: DB::Block::operator bool() const
2023.08.18 12:54:15.638101 [ 571 ] {} <Fatal> BaseDaemon: 16.4. inlined from ./build_docker/./src/Core/Block.h:118: DB::Block::operator!() const
2023.08.18 12:54:15.638111 [ 571 ] {} <Fatal> BaseDaemon: 16. ./build_docker/./src/Interpreters/ExpressionActions.cpp:776: DB::ExpressionActions::execute(DB::Block&, bool) const @ 0x000000003660ca57 in /workspace/clickhouse
2023.08.18 12:54:15.668285 [ 571 ] {} <Fatal> BaseDaemon: 17.1. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:815: std::shared_ptr<DB::IAST>::operator->[abi:v15000]() const
2023.08.18 12:54:15.668341 [ 571 ] {} <Fatal> BaseDaemon: 17. ./build_docker/./src/Storages/VirtualColumnUtils.cpp:244: DB::VirtualColumnUtils::filterBlockWithQuery(std::shared_ptr<DB::IAST> const&, DB::Block&, std::shared_ptr<DB::Context const>, std::shared_ptr<DB::IAST>) @ 0x00000000383cd8fd in /workspace/clickhouse
2023.08.18 12:54:15.763416 [ 571 ] {} <Fatal> BaseDaemon: 18.1. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/string:843: basic_string<std::nullptr_t>
2023.08.18 12:54:15.763494 [ 571 ] {} <Fatal> BaseDaemon: 18. ./build_docker/./src/Storages/MergeTree/MergeTreeDataSelectExecutor.cpp:793: DB::MergeTreeDataSelectExecutor::filterPartsByVirtualColumns(DB::MergeTreeData const&, std::vector<std::shared_ptr<DB::IMergeTreeDataPart const>, std::allocator<std::shared_ptr<DB::IMergeTreeDataPart const>>> const&, std::shared_ptr<DB::IAST> const&, std::shared_ptr<DB::Context const>) @ 0x00000000389ecdef in /workspace/clickhouse
2023.08.18 12:54:15.851873 [ 571 ] {} <Fatal> BaseDaemon: 19.1. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/optional:344: std::__optional_storage_base<std::unordered_set<String, std::hash<String>, std::equal_to<String>, std::allocator<String>>, false>::has_value[abi:v15000]() const
2023.08.18 12:54:15.851931 [ 571 ] {} <Fatal> BaseDaemon: 19.2. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/optional:998: std::optional<std::unordered_set<String, std::hash<String>, std::equal_to<String>, std::allocator<String>>>::operator bool[abi:v15000]() const
2023.08.18 12:54:15.851942 [ 571 ] {} <Fatal> BaseDaemon: 19. ./build_docker/./src/Processors/QueryPlan/ReadFromMergeTree.cpp:1427: DB::ReadFromMergeTree::selectRangesToReadImpl(std::vector<std::shared_ptr<DB::IMergeTreeDataPart const>, std::allocator<std::shared_ptr<DB::IMergeTreeDataPart const>>>, std::vector<std::shared_ptr<DB::AlterConversions const>, std::allocator<std::shared_ptr<DB::AlterConversions const>>>, std::shared_ptr<DB::StorageInMemoryMetadata const> const&, std::shared_ptr<DB::StorageInMemoryMetadata const> const&, DB::SelectQueryInfo const&, std::shared_ptr<DB::Context const>, unsigned long, std::shared_ptr<std::unordered_map<String, long, std::hash<String>, std::equal_to<String>, std::allocator<std::pair<String const, long>>>>, DB::MergeTreeData const&, std::vector<String, std::allocator<String>> const&, bool, Poco::Logger*, std::optional<DB::ReadFromMergeTree::Indexes>&) @ 0x0000000039a83d65 in /workspace/clickhouse
2023.08.18 12:54:15.939065 [ 571 ] {} <Fatal> BaseDaemon: 20. ./build_docker/./src/Processors/QueryPlan/ReadFromMergeTree.cpp:1373: DB::ReadFromMergeTree::selectRangesToRead(std::vector<std::shared_ptr<DB::IMergeTreeDataPart const>, std::allocator<std::shared_ptr<DB::IMergeTreeDataPart const>>>, std::vector<std::shared_ptr<DB::AlterConversions const>, std::allocator<std::shared_ptr<DB::AlterConversions const>>>, std::shared_ptr<DB::PrewhereInfo> const&, DB::ActionDAGNodes const&, std::shared_ptr<DB::StorageInMemoryMetadata const> const&, std::shared_ptr<DB::StorageInMemoryMetadata const> const&, DB::SelectQueryInfo const&, std::shared_ptr<DB::Context const>, unsigned long, std::shared_ptr<std::unordered_map<String, long, std::hash<String>, std::equal_to<String>, std::allocator<std::pair<String const, long>>>>, DB::MergeTreeData const&, std::vector<String, std::allocator<String>> const&, bool, Poco::Logger*, std::optional<DB::ReadFromMergeTree::Indexes>&) @ 0x0000000039a80c7e in /workspace/clickhouse
2023.08.18 12:54:16.027691 [ 571 ] {} <Fatal> BaseDaemon: 21. ./build_docker/./src/Processors/QueryPlan/ReadFromMergeTree.cpp:1164: DB::ReadFromMergeTree::selectRangesToRead(std::vector<std::shared_ptr<DB::IMergeTreeDataPart const>, std::allocator<std::shared_ptr<DB::IMergeTreeDataPart const>>>, std::vector<std::shared_ptr<DB::AlterConversions const>, std::allocator<std::shared_ptr<DB::AlterConversions const>>>) const @ 0x0000000039a804c5 in /workspace/clickhouse
2023.08.18 12:54:16.118593 [ 571 ] {} <Fatal> BaseDaemon: 22. ./build_docker/./src/Processors/QueryPlan/ReadFromMergeTree.cpp:1680: DB::ReadFromMergeTree::getAnalysisResult() const @ 0x0000000039a8a8c3 in /workspace/clickhouse
2023.08.18 12:54:16.198835 [ 571 ] {} <Fatal> BaseDaemon: 23. ./build_docker/./src/Processors/QueryPlan/ReadFromMergeTree.cpp:1789: DB::ReadFromMergeTree::initializePipeline(DB::QueryPipelineBuilder&, DB::BuildQueryPipelineSettings const&) @ 0x0000000039a8d1a0 in /workspace/clickhouse
2023.08.18 12:54:16.208162 [ 571 ] {} <Fatal> BaseDaemon: 24. ./build_docker/./src/Processors/QueryPlan/ISourceStep.cpp:24: DB::ISourceStep::updatePipeline(std::vector<std::unique_ptr<DB::QueryPipelineBuilder, std::default_delete<DB::QueryPipelineBuilder>>, std::allocator<std::unique_ptr<DB::QueryPipelineBuilder, std::default_delete<DB::QueryPipelineBuilder>>>>, DB::BuildQueryPipelineSettings const&) @ 0x0000000039a27dbb in /workspace/clickhouse
2023.08.18 12:54:16.235805 [ 571 ] {} <Fatal> BaseDaemon: 25.1. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/__memory/unique_ptr.h:302: std::unique_ptr<DB::QueryPipelineBuilder, std::default_delete<DB::QueryPipelineBuilder>>::reset[abi:v15000](DB::QueryPipelineBuilder*)
2023.08.18 12:54:16.235859 [ 571 ] {} <Fatal> BaseDaemon: 25.2. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/__memory/unique_ptr.h:225: std::unique_ptr<DB::QueryPipelineBuilder, std::default_delete<DB::QueryPipelineBuilder>>::operator=[abi:v15000](std::unique_ptr<DB::QueryPipelineBuilder, std::default_delete<DB::QueryPipelineBuilder>>&&)
2023.08.18 12:54:16.235869 [ 571 ] {} <Fatal> BaseDaemon: 25. ./build_docker/./src/Processors/QueryPlan/QueryPlan.cpp:189: DB::QueryPlan::buildQueryPipeline(DB::QueryPlanOptimizationSettings const&, DB::BuildQueryPipelineSettings const&) @ 0x0000000039a589e1 in /workspace/clickhouse

@alexey-milovidov alexey-milovidov merged commit 00e2e31 into ClickHouse:master Aug 18, 2023
272 of 274 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels
can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logical error: Trying to use set before it has been built (with timeout_overflow_mode = 'break')
3 participants
@canhld94 @robot-clickhouse @alexey-milovidov