New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed SELECTing from ReplacingMergeTree with do_not_merge_across_partitions_select_final #53511
Fixed SELECTing from ReplacingMergeTree with do_not_merge_across_partitions_select_final #53511
Conversation
…itions_select_final
This is an automated comment for commit f896c63 with description of existing statuses. It's updated for the latest CI running
|
Right now |
try to merge with master. |
…eTree-do_not_merge_across_partitions_select_final
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change LGTM.
@Enmk, would you like to continue? |
Sure, was a bit busy with something else, but definitely want to finish this one. |
…_across_partitions_select_final
It looks like rabbitMQ service failed to start, in ClickHouse Integration Tests (asan) [4/6] Figuring out why... |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed ReplacingMergeTree to properly process single-partition cases when
do_not_merge_across_partitions_select_final=1
. PreviouslySELECT
could return rows that were marked as deleted.Closes: #49685