New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: Flush async insert queue first on shutdown #53547
Merged
CurtizJ
merged 3 commits into
ClickHouse:master
from
joelynch:shutdown-async-insert-queue-first
Aug 24, 2023
Merged
bugfix: Flush async insert queue first on shutdown #53547
CurtizJ
merged 3 commits into
ClickHouse:master
from
joelynch:shutdown-async-insert-queue-first
Aug 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelynch
changed the title
Flush async insert queue first on shutdown
bugfix: Flush async insert queue first on shutdown
Aug 18, 2023
alexey-milovidov
added
the
can be tested
Allows running workflows for external contributors
label
Aug 18, 2023
robot-ch-test-poll
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Aug 18, 2023
This is an automated comment for commit 075c026 with description of existing statuses. It's updated for the latest CI running
|
CurtizJ
approved these changes
Aug 19, 2023
Added a test |
joelynch
force-pushed
the
shutdown-async-insert-queue-first
branch
from
August 21, 2023 10:59
2c14834
to
7eef0bd
Compare
Some errors in CI but seem unrelated to this change |
joelynch
force-pushed
the
shutdown-async-insert-queue-first
branch
from
August 22, 2023 07:20
7eef0bd
to
b24d166
Compare
Fixes bug where on graceful shutdown the database catalog is shutdown before queries in the async insert queue run, causing all the queries to fail and data to be lost.
joelynch
force-pushed
the
shutdown-async-insert-queue-first
branch
from
August 23, 2023 13:00
b24d166
to
075c026
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-bugfix
Pull request with bugfix, not backported by default
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where on graceful shutdown the database catalog is shutdown before queries in the async insert queue run, causing all the queries to fail and data to be lost.
Can easily recreate by running
then shutting down the server. Expected behaviour: when ClickHouse is restarted, table
test
has 1 row. Actual behaviour: Clickhouse logs an ERROR and when restarted tabletest
has 0 rows.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix bug in flushing of async insert queue on graceful shutdown.