Remove unneeded columns from logs #53601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
The
microseconds
column is removed from thesystem.text_log
, and themilliseconds
column is removed from thesystem.metric_log
, because they are redundant in the presence of theevent_time_microseconds
column.Back story: I've initially added
milliseconds
as a separate column toevent_time
, because it is the proper ClickHouse way (better compression, you don't pay for what you don't request). But eventually, other contributors added yet anotherevent_time_microseconds
column, defeating my principles.