Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number of dropped granules in EXPLAIN PLAN index=1 #53616

Merged
merged 14 commits into from Aug 24, 2023

Conversation

wzb5212
Copy link
Contributor

@wzb5212 wzb5212 commented Aug 20, 2023

Fixes #52107
Fixes #52637

CREATE TABLE test_skip_idx
(
    `id` UInt32,
    INDEX name_idx_g2 id TYPE minmax GRANULARITY 2,
    INDEX name_idx_g1 id TYPE minmax GRANULARITY 1
)
ENGINE = MergeTree
ORDER BY tuple()
SETTINGS index_granularity = 1, index_granularity_bytes = 0;

INSERT INTO test_skip_idx SELECT number FROM system.numbers LIMIT 5 OFFSET 1;

EXPLAIN indexes = 1 SELECT * FROM test_skip_idx WHERE id < 2;
┌─explain───────────────────────────────────────┐
│ Expression ((Projection + Before ORDER BY))   │
│   Filter (WHERE)                              │
│     ReadFromMergeTree (default.test_skip_idx) │
│     Indexes:                                  │
│       Skip                                    │
│         Name: name_idx_g2                     │
│         Description: minmax GRANULARITY 2     │
│         Parts: 1/1                            │
│         Granules: 3/5                         │
│       Skip                                    │
│         Name: name_idx_g1                     │
│         Description: minmax GRANULARITY 1     │
│         Parts: 1/1                            │
│         Granules: 1/3                         │
└───────────────────────────────────────────────┘

EXPLAIN indexes = 1 SELECT * FROM test_skip_idx WHERE id < 3;
┌─explain───────────────────────────────────────┐
│ Expression ((Projection + Before ORDER BY))   │
│   Filter (WHERE)                              │
│     ReadFromMergeTree (default.test_skip_idx) │
│     Indexes:                                  │
│       Skip                                    │
│         Name: name_idx_g2                     │
│         Description: minmax GRANULARITY 2     │
│         Parts: 1/1                            │
│         Granules: 3/5                         │
│       Skip                                    │
│         Name: name_idx_g1                     │
│         Description: minmax GRANULARITY 1     │
│         Parts: 1/1                            │
│         Granules: 2/3                         │
└───────────────────────────────────────────────┘


## expected behavior

EXPLAIN indexes = 1 SELECT * FROM test_skip_idx WHERE id < 2;
┌─explain───────────────────────────────────────┐
│ Expression ((Projection + Before ORDER BY))   │
│   Filter (WHERE)                              │
│     ReadFromMergeTree (default.test_skip_idx) │
│     Indexes:                                  │
│       Skip                                    │
│         Name: name_idx_g2                     │
│         Description: minmax GRANULARITY 2     │
│         Parts: 1/1                            │
│         Granules: 2/5                         │
│       Skip                                    │
│         Name: name_idx_g1                     │
│         Description: minmax GRANULARITY 1     │
│         Parts: 1/1                            │
│         Granules: 1/2                         │
└───────────────────────────────────────────────┘

EXPLAIN indexes = 1 SELECT * FROM test_skip_idx WHERE id < 3;
┌─explain───────────────────────────────────────┐
│ Expression ((Projection + Before ORDER BY))   │
│   Filter (WHERE)                              │
│     ReadFromMergeTree (default.test_skip_idx) │
│     Indexes:                                  │
│       Skip                                    │
│         Name: name_idx_g2                     │
│         Description: minmax GRANULARITY 2     │
│         Parts: 1/1                            │
│         Granules: 2/5                         │
│       Skip                                    │
│         Name: name_idx_g1                     │
│         Description: minmax GRANULARITY 1     │
│         Parts: 1/1                            │
│         Granules: 2/2                         │
└───────────────────────────────────────────────┘

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed a bug in EXPLAIN PLAN index=1 where the number of dropped granules was incorrect

@wzb5212 wzb5212 changed the title Fix bad size of mark skip index Fix wrong skip granule number Aug 20, 2023
@clickhouse-ci
Copy link

clickhouse-ci bot commented Aug 20, 2023

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: Changelog entry required for category 'Bug Fix (user-visible misbehavior in an official stable release)'

@ucasfl ucasfl added the can be tested Allows running workflows for external contributors label Aug 20, 2023
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-bugfix Pull request with bugfix, not backported by default label Aug 20, 2023
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Aug 20, 2023

This is an automated comment for commit 8365a36 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
Bugfix validate checkChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 failure
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@wzb5212 wzb5212 closed this Aug 20, 2023
@alexey-milovidov
Copy link
Member

@wzb5212 why closed?

@wzb5212
Copy link
Contributor Author

wzb5212 commented Aug 21, 2023

@wzb5212 why closed?

Just a moment, let me check the code.

@wzb5212 wzb5212 reopened this Aug 21, 2023
@wzb5212
Copy link
Contributor Author

wzb5212 commented Aug 22, 2023

@alexey-milovidov please take a look.

@rschu1ze rschu1ze self-assigned this Aug 22, 2023
@rschu1ze rschu1ze changed the title Fix wrong skip granule number Fix statistics about skip granule number Aug 23, 2023
@rschu1ze rschu1ze changed the title Fix statistics about skip granule number Fix number of dropped granules in EXPLAIN PLAN index=1 Aug 23, 2023
@rschu1ze rschu1ze merged commit 45d924c into ClickHouse:master Aug 24, 2023
266 of 272 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
5 participants