Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc. Cache is not supported for local disks anymore #53707

Merged
merged 1 commit into from Aug 22, 2023

Conversation

den-crane
Copy link
Contributor

related to #53670

#48791

Changelog category (leave one):

  • Documentation (changelog entry is not required)

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-documentation Documentation PRs for the specific code PR label Aug 22, 2023
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Aug 22, 2023

This is an automated comment for commit 0713dc5 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟢 success

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
Docs CheckBuilds and tests the documentation🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success

@alexey-milovidov alexey-milovidov self-assigned this Aug 22, 2023
@alexey-milovidov alexey-milovidov merged commit b78bd47 into ClickHouse:master Aug 22, 2023
15 checks passed
@alexey-milovidov
Copy link
Member

It is also supported for Web and S3Plain, and should be supported for Encrypted.
I was expecting it should work for every disk type.

@den-crane
Copy link
Contributor Author

Actually if local_blob_storage is an emulation of remote storage then this has no sense

@UnamedRus
Copy link
Contributor

Alexey is opposing of using local_blob_storage as zero copy support over posix for users.

#52093 (comment)

Explicit implementation have potential to get his approval, i hope so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-documentation Documentation PRs for the specific code PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants