Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Userspace page cache #53770

Merged
merged 16 commits into from
Feb 29, 2024
Merged

Userspace page cache #53770

merged 16 commits into from
Feb 29, 2024

Conversation

al13n321
Copy link
Member

@al13n321 al13n321 commented Aug 24, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

A cache that takes all available memory.

Currently only integrated with S3 disks. Use setting use_page_cache_for_disks_without_file_cache to enable. Probably not useful when file cache is enabled.

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 24, 2023
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Aug 24, 2023

This is an automated comment for commit d7c167e with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

Copy link
Member

@antaljanosbenjamin antaljanosbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit slow with the review, but I will try to finish it tomorrow.

src/Common/PageCache.h Outdated Show resolved Hide resolved
src/Common/PageCache.h Outdated Show resolved Hide resolved
src/Common/PageCache.cpp Outdated Show resolved Hide resolved
src/Common/PageCache.cpp Outdated Show resolved Hide resolved
src/Common/PageCache.cpp Outdated Show resolved Hide resolved
src/Common/PageCache.cpp Outdated Show resolved Hide resolved
src/Interpreters/InterpreterSystemQuery.cpp Outdated Show resolved Hide resolved
Copy link
Member

@antaljanosbenjamin antaljanosbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a compilation error in code. Apart from that I didn't spot any obvious errors, however regarding the buffers my understanding is somewhat limited, as they are very complex and I have zero experience working with them. However I tried my best and the code you wrote make sense to me. If we are wrong, then the tests will let us know.

src/Common/PageCache.cpp Outdated Show resolved Hide resolved
src/IO/CachedInMemoryReadBufferFromFile.cpp Show resolved Hide resolved
@al13n321
Copy link
Member Author

(I'm still debugging the bugs that CI found.)

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-status-⏳ PR with some pending statuses label Sep 16, 2023
@robot-ch-test-poll4 robot-ch-test-poll4 added pr-status-❌ PR with some error/faliure statuses and removed pr-status-⏳ PR with some pending statuses labels Sep 16, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added submodule changed At least one submodule changed in this PR. pr-status-⏳ PR with some pending statuses and removed pr-status-❌ PR with some error/faliure statuses labels Sep 18, 2023
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added pr-status-❌ PR with some error/faliure statuses and removed pr-status-⏳ PR with some pending statuses labels Sep 18, 2023
@robot-ch-test-poll3 robot-ch-test-poll3 removed the submodule changed At least one submodule changed in this PR. label Sep 23, 2023
@alexey-milovidov
Copy link
Member

Please resolve conflicts.

@al13n321 al13n321 merged commit 7b55c61 into master Feb 29, 2024
232 of 240 checks passed
@al13n321 al13n321 deleted the pc branch February 29, 2024 11:27
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 29, 2024
@baibaichen
Copy link
Contributor

got build issue for both clang 16 and clang 17

/Parsers/ASTSystemQuery.cpp:155:13 error: enumeration value 'DROP_PAGE_CACHE' not handled in switch [-Werror,-Wswitch]
    switch (type)
            ^~~~
1 error generated.

tavplubix added a commit that referenced this pull request Feb 29, 2024
al13n321 added a commit that referenced this pull request Feb 29, 2024
* Userspace page cache

* Maybe it'll build this time, who knows.

* 'auto' went out of fashion, I guess

* Documentation, tsan workaround, metric 'UnreclaimableRss', disable page cache in the test that uses DatabaseOrdinary

* Moved CachedInMemoryReadBufferFromFile to object store level, changed settings, addressed other comments.

* Fix

* Another fix

* Fix restricted seek, fix ppc64le build

* Don't allow page cache with file cache

* Adjust tests a little

* Fix clang-tidy

* Conflicts

* Comments

* Maybe unbroke AsynchronousBoundedReadBuffer

* SettingsChangesHistory.h

* Fix warning in test
baibaichen added a commit to baibaichen/ClickHouse that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force tests The label does nothing, NOOP, None, nil pr-not-for-changelog This PR should not be mentioned in the changelog pr-status-❌ PR with some error/faliure statuses pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet