-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Userspace page cache #53770
Userspace page cache #53770
Conversation
This is an automated comment for commit d7c167e with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
65b5c19
to
94067ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit slow with the review, but I will try to finish it tomorrow.
c941744
to
1e62207
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a compilation error in code. Apart from that I didn't spot any obvious errors, however regarding the buffers my understanding is somewhat limited, as they are very complex and I have zero experience working with them. However I tried my best and the code you wrote make sense to me. If we are wrong, then the tests will let us know.
(I'm still debugging the bugs that CI found.) |
31e1123
to
70e8c53
Compare
25fd28b
to
1313a40
Compare
Please resolve conflicts. |
27662d8
to
7aa3ee7
Compare
…ge cache in the test that uses DatabaseOrdinary
… settings, addressed other comments.
got build issue for both clang 16 and clang 17
|
This reverts commit 7b55c61.
* Userspace page cache * Maybe it'll build this time, who knows. * 'auto' went out of fashion, I guess * Documentation, tsan workaround, metric 'UnreclaimableRss', disable page cache in the test that uses DatabaseOrdinary * Moved CachedInMemoryReadBufferFromFile to object store level, changed settings, addressed other comments. * Fix * Another fix * Fix restricted seek, fix ppc64le build * Don't allow page cache with file cache * Adjust tests a little * Fix clang-tidy * Conflicts * Comments * Maybe unbroke AsynchronousBoundedReadBuffer * SettingsChangesHistory.h * Fix warning in test
This reverts commit 7b55c61.
Changelog category (leave one):
A cache that takes all available memory.
Currently only integrated with S3 disks. Use setting
use_page_cache_for_disks_without_file_cache
to enable. Probably not useful when file cache is enabled.