-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue a warning instead of throwing when s3 zerocopy part metadata directory already exists #53794
Issue a warning instead of throwing when s3 zerocopy part metadata directory already exists #53794
Conversation
// Easier to re-fetch than to re-init part storage from existing files | ||
disk->removeRecursive(fs::path(path_to_clone) / relative_path / ""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better solution would be to directly initialize new part storage from existing files, but I haven't found a suitable way to do it so far
This is an automated comment for commit 1441f56 with description of existing statuses. It's updated for the latest CI running
|
Zero-copy replication is experimental, so we don't need backporting. |
The problem is that we backported another patch that modified this line, and behavior in 23.3 was changed. #50489 |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Revert old behavior on zerocopy s3 metadata creation: if a directory exists (and checksums match), re-fetch it instead of throwing.
In 23.7 #50489 (backported to 23.3.10) an exception is thrown if part metadata already exists. One of our clients encountered this issue, so a fix is proposed: back to 23.3.4 solution where a warning is issued in a log. Throwing an exception makes zerocopy replication unusable.