-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to hide settings in preprocessed configuration file #53818
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This is an automated comment for commit 92b89e8 with description of existing statuses. It's updated for the latest CI running
|
This comment was marked as outdated.
This comment was marked as outdated.
tests/integration/test_config_hidden_attributes/configs/config.xml
Outdated
Show resolved
Hide resolved
tests/integration/test_config_hidden_attributes/configs/config.xml
Outdated
Show resolved
Hide resolved
I am working on fixing the integration tests. It when ClickHouse is built with ASAN then in fails to restart ClickHouse in integration test using For example, def test_hide_in_preprocessed(started_cluster):
assert (
node.query(
"select value from system.server_settings where name ='max_thread_pool_free_size'"
)
== "2000\n"
)
node.restart_clickhouse()
assert (
node.query(
"select value from system.server_settings where name ='max_thread_pool_free_size'"
)
== "2000\n"
) It will display "Exception: Cannot start ClickHouse, see additional info in logs" which is produced by It's not clear how is it related with by code and with ASAN. But surely it's related. I am going to fix it. |
Thanks to ASAN build, probably the failed integration tests were fixed by changing: Node * new_node = xml_tree_copy->importNode(node, true); to NodePtr new_node = xml_tree_copy->importNode(node, true); Because NodePtr is AutoPtr: class AutoPtr
/// AutoPtr is a "smart" pointer for classes implementing
/// reference counting based garbage collection. |
@rschu1ze "All checks have passed". |
Closes #52207
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added the "hide_in_preprocessed" attribute to ClickHouse's server configuration XML dialect. This is a mechanism to hide certain settings from appearing in preprocessed server configuration files. Useful e.g. for passwords or private keys that should not appear verbatim in files.