Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restore setting "restore_broken_parts_as_detached" #53877

Conversation

vitlibar
Copy link
Member

@vitlibar vitlibar commented Aug 28, 2023

Changelog category:

  • Improvement

Changelog entry:

Added restore setting restore_broken_parts_as_detached: if it's true the RESTORE process won't stop on broken parts while restoring, instead all the broken parts will be copied to the detached folder with the prefix `broken-from-backup'. If it's false the RESTORE process will stop on the first broken part (if any). The default value is false.

Added backup setting check_parts: If it's true the BACKUP process will check that parts are not broken before putting them into a backup. The default value is true.

Before this PR a single broken part added to a backup could make the entire table non-restorable.

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-improvement Pull request with some product improvements label Aug 28, 2023
@robot-ch-test-poll4
Copy link
Contributor

robot-ch-test-poll4 commented Aug 28, 2023

This is an automated comment for commit 988fd9e with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟢 success

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@vitlibar vitlibar force-pushed the add-restore-setting-allow-broken-parts branch from a36beee to 27d1bf6 Compare August 29, 2023 13:04
@pufit pufit self-assigned this Aug 29, 2023
@vitlibar vitlibar marked this pull request as draft August 31, 2023 15:28
@vitlibar
Copy link
Member Author

I decided to change my solution in this PR, will update the PR soon. Please don't review it now, review it later :)

@vitlibar vitlibar force-pushed the add-restore-setting-allow-broken-parts branch from 27d1bf6 to 6463720 Compare September 4, 2023 16:52
@vitlibar vitlibar force-pushed the add-restore-setting-allow-broken-parts branch from 6463720 to 1bdc3a3 Compare September 4, 2023 16:54
@vitlibar vitlibar changed the title Add restore setting "allow_broken_parts" Add restore setting "restore_broken_parts_as_detached" Sep 4, 2023
@vitlibar vitlibar force-pushed the add-restore-setting-allow-broken-parts branch from 1bdc3a3 to 988fd9e Compare September 4, 2023 22:52
@vitlibar vitlibar marked this pull request as ready for review September 5, 2023 05:38
@vitlibar
Copy link
Member Author

vitlibar commented Sep 5, 2023

I decided to change my solution in this PR, will update the PR soon. Please don't review it now, review it later :)

done, please review it now :)

Copy link
Member

@pufit pufit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 merged commit 7403ee6 into ClickHouse:master Sep 5, 2023
276 checks passed
@vitlibar vitlibar deleted the add-restore-setting-allow-broken-parts branch September 7, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants