New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not implicitly read pk and version columns in lonely parts if unnecessary #53919
Do not implicitly read pk and version columns in lonely parts if unnecessary #53919
Conversation
This is a huge improvement! I didn't expect we don't have it already :) |
This is an automated comment for commit 8a9b544 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
…onely parts Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
a7e4d2e
to
11c9424
Compare
The stateless test is flaky because it relies on merges, will try to make it stable.
--> indeed this bring performance improvement (will be more clear if we set max_threads=1). Will add own performance test as well. |
cc @jorisgio |
1680090
to
06afe0c
Compare
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2e7db16
to
964412e
Compare
@KochetovNicolai @alexey-milovidov pls help to review when you have time [THANKS] |
And baseline
|
…_parts Do not implicitly read pk and version columns in lonely parts if unnecessary Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
When query has
FINAL
but we enabledo_not_merge_across_partitions_select_final
, no need to implicitly read pk and version columns for lonely parts.Implementation: construct two group of pipes
Convert header if needed (final header is from non-merging pipes, if it's not empty) and unite all pipes
Inspired by #43296